Building faiss static and cpu-only for the ann-benchmarks #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for the #1814
This change builds FAISS the second time using the already downloaded sources - as a static library and without GPU components (target
faiss::faiss_cpu). The build times are very short and the benchmark executables linked to this lib are still small, hence I think this is a reasonable approach to allow building GPU and CPU-only benchmarks at the same time.The main benefit, especially useful for benchmarking-during-development, is that the resulting
FAISS_CPU_*components do not depend on CUDA runtime and thus can be copied to a CPU-ONLY node.