Skip to content

Commit

Permalink
Merge branch 'branch-24.06' into cagra-add-new-vectors
Browse files Browse the repository at this point in the history
  • Loading branch information
enp1s0 authored Apr 16, 2024
2 parents d6c5f70 + e977d2e commit c5319dc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions cpp/include/raft/neighbors/detail/cagra/cagra_search.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ void search_main_core(
CagraSampleFilterT sample_filter = CagraSampleFilterT())
{
RAFT_LOG_DEBUG("# dataset size = %lu, dim = %lu\n",
static_cast<size_t>(index.data().n_rows()),
static_cast<size_t>(index.data().dim()));
static_cast<size_t>(dataset_desc.size),
static_cast<size_t>(dataset_desc.dim));
RAFT_LOG_DEBUG("# query size = %lu, dim = %lu\n",
static_cast<size_t>(queries.extent(0)),
static_cast<size_t>(queries.extent(1)));
Expand Down
9 changes: 5 additions & 4 deletions docs/source/developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,14 @@ python ./cpp/scripts/include_checker.py --inplace [cpp/include cpp/test ... list
```

### Copyright header
[copyright.py](https://github.com/rapidsai/raft/blob/branch-24.06/ci/checks/copyright.py) checks the Copyright header for all git-modified files
RAPIDS [pre-commit-hooks](https://github.com/rapidsai/pre-commit-hooks) checks the Copyright
header for all git-modified files.

Manually, you can run the following to bulk-fix the header if only the years need to be updated:
Manually, you can run the following to bulk-fix the header on all files in the repository:
```bash
python ./ci/checks/copyright.py --update-current-year
pre-commit run -a verify-copyright
```
Keep in mind that this only applies to files tracked by git and having been modified.
Keep in mind that this only applies to files tracked by git that have been modified.

## Error handling
Call CUDA APIs via the provided helper macros `RAFT_CUDA_TRY`, `RAFT_CUBLAS_TRY` and `RAFT_CUSOLVER_TRY`. These macros take care of checking the return values of the used API calls and generate an exception when the command is not successful. If you need to avoid an exception, e.g. inside a destructor, use `RAFT_CUDA_TRY_NO_THROW`, `RAFT_CUBLAS_TRY_NO_THROW ` and `RAFT_CUSOLVER_TRY_NO_THROW`. These macros log the error but do not throw an exception.
Expand Down

0 comments on commit c5319dc

Please sign in to comment.