Skip to content

Commit

Permalink
Remove supports_streams from custom MRs
Browse files Browse the repository at this point in the history
  • Loading branch information
harrism committed Jan 24, 2024
1 parent c90cdfa commit 14a394c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
10 changes: 1 addition & 9 deletions cpp/bench/ann/src/common/cuda_huge_page_resource.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ class cuda_huge_page_resource final : public rmm::mr::device_memory_resource {
cuda_huge_page_resource& operator=(cuda_huge_page_resource const&) = default;
cuda_huge_page_resource& operator=(cuda_huge_page_resource&&) = default;

/**
* @brief Query whether the resource supports use of non-null CUDA streams for
* allocation/deallocation. `cuda_huge_page_resource` does not support streams.
*
* @returns bool false
*/
[[nodiscard]] bool supports_streams() const noexcept override { return false; }

/**
* @brief Query whether the resource supports the get_mem_info API.
*
Expand Down Expand Up @@ -129,4 +121,4 @@ class cuda_huge_page_resource final : public rmm::mr::device_memory_resource {
return std::make_pair(free_size, total_size);
}
};
} // namespace raft::mr
} // namespace raft::mr
12 changes: 1 addition & 11 deletions cpp/bench/ann/src/common/cuda_pinned_resource.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@ class cuda_pinned_resource final : public rmm::mr::device_memory_resource {
cuda_pinned_resource& operator=(cuda_pinned_resource const&) = default;
cuda_pinned_resource& operator=(cuda_pinned_resource&&) = default;

/**
* @brief Query whether the resource supports use of non-null CUDA streams for
* allocation/deallocation. `cuda_pinned_resource` does not support streams.
*
* @returns bool false
*/
[[nodiscard]] bool supports_streams() const noexcept override { return false; }

/**
* @brief Query whether the resource supports the get_mem_info API.
*
Expand All @@ -66,8 +58,6 @@ class cuda_pinned_resource final : public rmm::mr::device_memory_resource {
*
* The returned pointer has at least 256B alignment.
*
* @note Stream argument is ignored
*
* @throws `rmm::bad_alloc` if the requested allocation could not be fulfilled
*
* @param bytes The size, in bytes, of the allocation
Expand Down Expand Up @@ -127,4 +117,4 @@ class cuda_pinned_resource final : public rmm::mr::device_memory_resource {
return std::make_pair(free_size, total_size);
}
};
} // namespace raft::mr
} // namespace raft::mr

0 comments on commit 14a394c

Please sign in to comment.