Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rapids-version argument to verify-alpha-spec #44

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 2, 2024

Projects that don't use RAPIDS version conventions should still be able to depend on RAPIDS packages. Add a --rapids-version argument to verify-alpha-spec so that the hook can still be used.

Closes #43

Projects that don't use RAPIDS version conventions should still
be able to depend on RAPIDS packages. Add a --rapids-version argument
to verify-alpha-spec so that the hook can still be used.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 2, 2024 16:08
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard for me to review this without fully understanding the way you envision it being used.

I'm approving based on the assumption that this works as I described below. If it doesn't, could you correct my understanding and give me a chance to review again?


Are you envisioning that, for example, ucxx's .pre-commit-config.yaml will have something like the following?

  - repo: https://github.com/rapidsai/pre-commit-hooks
    rev: v0.2.0
    hooks:
      - id: verify-alpha-spec
        args: ["--rapids-version=24.08"]

And that its ci/release/update-version.sh would then have code to update that each time a new release is cut? Similar to this?

https://github.com/rapidsai/ucxx/blob/3985977756c0b21578a152e9f8d3afa17d3f8ea8/ci/release/update-version.sh#L38

If so, I support this approach of adding an argument that allows optionally providing a RAPIDS version that overrides whatever's in the VERSION file. It's simpler and cheaper than other options I can think of for solving this problem (all of which involve having rapids-metadata know something about the ucx*-to-RAPIDS version mapping + the hook needing to know that it's in one of the repos following the ucx* versioning scheme).

@KyleFromNVIDIA
Copy link
Contributor Author

@jameslamb Yes, that's exactly what I'm envisioning. With that being said, do you think this is ready to merge?

@jameslamb
Copy link
Member

Yep definitely, thanks for confirming I understood how this was intended to work.

@KyleFromNVIDIA KyleFromNVIDIA merged commit 701c55b into rapidsai:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify-alpha-spec hook doesn't work for non-RAPIDS-versioned projects
2 participants