manage dependencies with rapids-dependency-file-generator #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #115
When #115 is complete, this project will need access to some of the same dependency information in several different places:
setup.py
/pyproject.toml
(for wheel-building)This proposes using
rapids-dependency-file-generator
to keep those sets of dependencies consistent across those locations, and to automate some of the work of updating them. We've found this to be really helpful across other RAPIDS projects.For an example of this, see rapidsai/cugraph#4521. All the changes to
pyproject.toml
and conda env YAML files there were driven by just updatingdependencies.yaml
and runningrapids-dependency-file-generator --clean
.Other changes proposed here:
!=3.30.0
constraint onCMake
pre-commit
passesNotes for Revieweris
In a future PR, I'll propose switching from a
setup.py
file to apyproject.toml
, and automatically updating thatpyproject.toml
via thisrapids-dependency-file-generator
mechanism. That way, constraints likelegate-core=24.06.*
won't need to be duplicated in multiple places.