Readd fixed cuSpatial notebooks #703
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jameslamb (for awareness) |
|
I've restarted CI here, to pull in the latest changes and see if this is fixed. |
jameslamb
reviewed
Jan 31, 2025
| @@ -22,17 +22,11 @@ | |||
| ] | |||
| ignored_filenames = ["-csv", "benchmark", "target", "performance"] | |||
| ignored_notebooks = [ | |||
| 'cusignal/api_guide/io_examples.ipynb', # 26gb data download | |||
There was a problem hiding this comment.
We can remove this too. cusignal is no longer a part of RAPIDS:
- https://docs.rapids.ai/notices/rsn0032/
- https://github.com/rapidsai/cusignal (archived Septemebr 25, 2023)
|
I've updated this to 25.02, let's see how it goes. I expect that Tracking issue for fixing that: #726 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cuSpatial notebooks ran into some issues near the 24.08 release. We opted to skip them and work on fixes in 24.10. As those fixes are now landing, try adding these notebooks back