Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cuspatial/trajectory_clustering.ipynb failure #726

Open
raydouglass opened this issue Jan 15, 2025 · 2 comments
Open

[BUG] cuspatial/trajectory_clustering.ipynb failure #726

raydouglass opened this issue Jan 15, 2025 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@raydouglass
Copy link
Member

Investigate failing cuspatial notebook: cuspatial/trajectory_clustering.ipynb

Ref: https://github.com/rapidsai/docker/actions/runs/12776630233/job/35657094304

@raydouglass raydouglass added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jan 15, 2025
@jameslamb
Copy link
Member

I just saw this too, in #727

Adding some logs for searchability:

Testing cuspatial/trajectory_clustering.ipynb
FileNotFoundError: [Errno 2] No such file or directory: 'trajectories_extracted.p'"

...
NameError: name 'trajectories' is not defined"]

(build link)

Interestingly, it does look like this is being run in cuSpatial CI. In a run of the pr workflow from yesterday (notebooks are not tested in nightlies there), I see the following:

STARTING: trajectory_clustering
--------------------------------------------------------------------------------
[NbConvertApp] Converting notebook ./trajectory_clustering.ipynb to script
[NbConvertApp] Writing 11966 bytes to /tmp/tmp.sIKbTCbHE0/trajectory_clustering-test.py
Running "ipython --colors=NoColor /tmp/tmp.sIKbTCbHE0/trajectory_clustering-test.py" on Tue Jan 28 16:54:26 UTC 2025

--2025-01-28 16:54:32--  https://data.rapids.ai/cuspatial/datasets/trajectories_extracted.p
Resolving data.rapids.ai (data.rapids.ai)... 13.249.126.16, 13.249.126.10, 13.249.126.83, ...
Connecting to data.rapids.ai (data.rapids.ai)|13.249.126.16|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 28919821 (28M) [text/x-pascal]
Saving to: ‘trajectories_extracted.p’

...
2025-01-28 16:54:33 (116 MB/s) - ‘trajectories_extracted.p’ saved [28919821/28919821]
...
DONE: trajectory_clustering

(build link)

@jameslamb
Copy link
Member

@isVoid at this point almost all of the cuSpatial notebooks are being skipped in this repo:

ignored_notebooks = [
'cusignal/api_guide/io_examples.ipynb', # 26gb data download
# following nbs are marked as skipped
'cugraph/algorithms/layout/Force-Atlas2.ipynb',
'cuspatial/binary_predicates.ipynb',
'cuspatial/cuproj_benchmark.ipynb',
# context on these being skipped: https://github.com/rapidsai/cuspatial/pull/1407
'cuspatial/cuspatial_api_examples.ipynb',
'cuspatial/nyc_taxi_years_correlation.ipynb',
# context on skip zipcodes: https://github.com/rapidsai/cuspatial/issues/1426
'cuspatial/ZipCodes_Stops_PiP_cuSpatial.ipynb',
]

When you have time, could you please help investigate these? It'd be good to figure out how to more reliably deliver a set of example notebooks for cuSpatial. I can help with replicating the failures from this project's CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants