[DO NOT MERGE] Test Python limited API compilation #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cugraph-ops fix PR here: https://github.com/rapidsai/cugraph-ops/pull/637 |
|
@vyasr is your intention to merge this into the repo, or just open this PR so you can validate the change in CI? |
|
@trxcllnt this is just for testing, and to make it easier to track changes in a way that's visible to others (and also to help collaboration since setting up an environment for testing this is a bit nontrivial). Hope that's all right. I'll mark the PR as DO NOT MERGE to clearly indicate that this isn't just temporarily in draft, it'll never be opened. |
vyasr
changed the title
This was referenced Apr 26, 2024
trxcllnt
reviewed
May 9, 2024
| @@ -15,7 +15,8 @@ repos: | |||
| - name: rmm | |||
| sub_dir: python/rmm | |||
| depends: [rmm] | |||
| args: {cmake: -DFIND_RMM_CPP=ON} | |||
| args: {cmake: -DFIND_RMM_CPP=ON -DCMAKE_CXX_FLAGS="'-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1'"} | |||
There was a problem hiding this comment.
Suggested change
| args: {cmake: -DFIND_RMM_CPP=ON -DCMAKE_CXX_FLAGS="'-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1'"} | |
| args: {cmake: -DFIND_RMM_CPP=ON -DCMAKE_CXX_FLAGS="-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1"} |
trxcllnt
reviewed
May 9, 2024
| @@ -84,11 +85,11 @@ repos: | |||
| - name: pylibraft | |||
| sub_dir: python/pylibraft | |||
| depends: [raft] | |||
| args: {cmake: -DFIND_RAFT_CPP=ON} | |||
| args: {cmake: -DFIND_RAFT_CPP=ON -DCMAKE_CXX_FLAGS="'-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1'"} | |||
There was a problem hiding this comment.
Suggested change
| args: {cmake: -DFIND_RAFT_CPP=ON -DCMAKE_CXX_FLAGS="'-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1'"} | |
| args: {cmake: -DFIND_RAFT_CPP=ON -DCMAKE_CXX_FLAGS="-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1"} |
trxcllnt
reviewed
May 9, 2024
| - name: raft-dask | ||
| sub_dir: python/raft-dask | ||
| depends: [raft] | ||
| args: {cmake: -DFIND_RAFT_CPP=ON} | ||
| args: {cmake: -DFIND_RAFT_CPP=ON -DCMAKE_CXX_FLAGS="'-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1'"} |
There was a problem hiding this comment.
Suggested change
| args: {cmake: -DFIND_RAFT_CPP=ON -DCMAKE_CXX_FLAGS="'-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1'"} | |
| args: {cmake: -DFIND_RAFT_CPP=ON -DCMAKE_CXX_FLAGS="-DPy_LIMITED_API=0x030B0000 -DCYTHON_LIMITED_API=1"} |
vyasr
force-pushed
the
testing/py_limited_api
branch
from
682e09a to
c9791a4
Compare
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is leveraging the convenience of the devcontainer framework for having a long-lived test of this functionality exist in a reproducible fashion.