Skip to content

Commit

Permalink
Various fixes to args (#397)
Browse files Browse the repository at this point in the history
There have been a number of changes to RAPIDS builds over the course of
this release and not all changes were fully propagated to the
devcontainers repo. This repo addresses the following:
- As of rapidsai/kvikio#369, kvikio produces
wheels, and rapidsai/kvikio#439 contains
critical fixes that allow the kvikio Python wheel to use the C++
libkvikio wheel. In RAPIDS Python builds we have consistently removed
support for the Python build triggering the C++ build as we have created
C++ wheels since in both conda and pip environments we now expect the
library to be found and we do not need to automatically support the more
esoteric use case of someone turning off build isolation but not having
the C++ library available (devs can handle this case themselves if they
wish). As a result, once rapidsai/kvikio#466 is
merged, the `FIND_KVIKIO_CPP` variable will be completely superfluous
and we can remove that here.
- As of rapidsai/cudf#16640 libcudf no longer
links to libarrow and `USE_LIBARROW_FROM_PYARROW` is no longer used.
- The libcudf and libcuspatial Python package builds in the devcontainer
should (like all other Python packages) omit the CUDA version suffix.
For that, they need to use the `rapids_build_backend_args`.
  • Loading branch information
vyasr authored Sep 23, 2024
1 parent 88c449f commit 09757b6
Showing 1 changed file with 7 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ repos:
- name: libkvikio
sub_dir: python/libkvikio
depends: [KvikIO]
args: {cmake: -DFIND_KVIKIO_CPP=ON, install: *rapids_build_backend_args}
args: {install: *rapids_build_backend_args}
- name: kvikio
sub_dir: python/kvikio
depends: [KvikIO]
args: {cmake: -DFIND_KVIKIO_CPP=ON, install: *rapids_build_backend_args}
args: {install: *rapids_build_backend_args}

- name: cudf
path: cudf
Expand All @@ -71,24 +71,22 @@ repos:
- name: cudf
sub_dir: cpp
depends: [KvikIO]
args:
cmake: |
$([ "pip" = ${PYTHON_PACKAGE_MANAGER} ] && echo -DUSE_LIBARROW_FROM_PYARROW=ON || echo)
- name: cudf_kafka
sub_dir: cpp/libcudf_kafka
depends: [cudf]
python:
- name: libcudf
sub_dir: python/libcudf
depends: [cudf]
args: {install: *rapids_build_backend_args}
- name: pylibcudf
sub_dir: python/pylibcudf
depends: [cudf]
args: {cmake: -DFIND_CUDF_CPP=ON, install: *rapids_build_backend_args}
args: {install: *rapids_build_backend_args}
- name: cudf
sub_dir: python/cudf
depends: [cudf]
args: {cmake: -DFIND_CUDF_CPP=ON, install: *rapids_build_backend_args}
args: {install: *rapids_build_backend_args}
- name: dask_cudf
sub_dir: python/dask_cudf
args: {install: *rapids_build_backend_args}
Expand Down Expand Up @@ -217,9 +215,7 @@ repos:
- name: cugraph_etl
sub_dir: cpp/libcugraph_etl
depends: [cudf, cugraph]
args:
cmake: $([ "pip" = ${PYTHON_PACKAGE_MANAGER} ] && echo -DUSE_LIBARROW_FROM_PYARROW=ON || echo)
install: *rapids_build_backend_args
args: {install: *rapids_build_backend_args}
python:
- name: pylibcugraph
sub_dir: python/pylibcugraph
Expand Down Expand Up @@ -259,6 +255,7 @@ repos:
- name: libcuspatial
sub_dir: python/libcuspatial
depends: [cuspatial]
args: {install: *rapids_build_backend_args}
- name: cuproj
sub_dir: python/cuproj
depends: [rmm]
Expand Down

0 comments on commit 09757b6

Please sign in to comment.