-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for prepending conda channels via the CLI. #67
Conversation
To solve rapidsai/build-planning#22, I'm thinking we'll do this kind of thing in each RAPIDS repo CI test script: rapids-logger "Downloading artifacts from previous jobs"
CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)
rapids-dependency-file-generator \
--output conda \
--file_key test_python \
--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" \
--prepend-channels "${CPP_CHANNEL};${PYTHON_CHANNEL}" | tee env.yaml
rapids-mamba-retry env create --force -f env.yaml -n test We would modify the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
# [1.9.0](v1.8.0...v1.9.0) (2024-02-22) ### Features * Add support for prepending conda channels via the CLI. ([#67](#67)) ([720f2cd](720f2cd))
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR creates a conda environment containing both test dependencies and cuml packages. This is a workaround for some issues seen with conda being unable to downgrade from Arrow 15 (in the initial environment with test dependencies) to Arrow 14 (currently pinned by cudf, which is a dependency of cuml). This is a partial solution for rapidsai/build-planning#22. (More work is needed for other RAPIDS repos.) Depends on rapidsai/dependency-file-generator#67. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Charles Blackmon-Luca (https://github.com/charlesbluca) - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) - Jake Awe (https://github.com/AyodeAwe) - https://github.com/jakirkham - Dante Gama Dessavre (https://github.com/dantegd) URL: #5781
# [1.9.0](rapidsai/dependency-file-generator@v1.8.0...v1.9.0) (2024-02-22) ### Features * Add support for prepending conda channels via the CLI. ([#67](rapidsai/dependency-file-generator#67)) ([050aa4d](rapidsai/dependency-file-generator@050aa4d))
This adds an option
--prepend-channels "my_channel;my_other_channel"
to therapids-dependency-file-generator
CLI. This will allow us to userapids-dependency-file-generator
with local channels containing PR artifacts fetched in CI workflows. If we combine this feature with some small changes independencies.yaml
, we will be able to generate the entire CI environment in one pass rather than generating an environment with test dependencies and then installing the packages (e.g.libcuml
andlibcuml-tests
) in a separate step.This option is modeled after
conda config --prepend channels new_channel
(reference).See original proposal in rapidsai/cuml#5781 (comment) (this PR is slightly improved from that proposal).
This is a partial solution for rapidsai/build-planning#22.