Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] cuxfilter v24.10 #636

Merged
merged 20 commits into from
Oct 9, 2024
Merged

[RELEASE] cuxfilter v24.10 #636

merged 20 commits into from
Oct 9, 2024

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-24.10 and v24.10 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-24.10 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-24.10 into main for the release

raydouglass and others added 19 commits July 19, 2024 15:07
@raydouglass
DOC v24.10 Updates [skip ci]
eb6652b
@jameslamb
Merge branch-24.08 into branch-24.10
16e4e3d
@AyodeAwe
Merge pull request #611 from jameslamb/branch-24.10-merge-24.08
effdb6c 
Branch 24.10 merge 24.08
@GPUtester
Merge pull request #613 from rapidsai/branch-24.08
9e10d06 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #615 from rapidsai/branch-24.08
4fc4951 
Forward-merge branch-24.08 into branch-24.10
@AjayThorve
Fix tests (#620)
c325c7f 
This PR fixes

1. [failing tests](https://github.com/rapidsai/cuxfilter/actions/runs/10303789190/job/28671747182?pr=617), which were caused by duplicate columns in the core_graph source_df. 

2. Failing [external tests](https://github.com/rapidsai/cuxfilter/actions/workflows/test-external.yaml)

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Bradley Dice (https://github.com/bdice)
  - Allan (https://github.com/exactlyallan)

URL: #620
@bdice
Improve update-version.sh (#616)
95bd8db 
A few small tweaks to `update-version.sh` for alignment across RAPIDS.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Ray Douglass (https://github.com/raydouglass)

URL: #616
@KyleFromNVIDIA
Update pre-commit hooks (#617)
76fc52e 
This PR updates pre-commit hooks to the latest versions that are supported without causing style check errors.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #617
@AjayThorve
Fix/external tests (#621)
a00bf9d 
This PR aims to fix the [unbound input variable](https://github.com/rapidsai/cuxfilter/actions/runs/10402536485/job/28807203732#step:9:734) issue when running the external testing workflow

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #621
@Matt711
[BUG] Fix cudf.pandas integration issues with cuxfilter (#619)
cc18207 
THis PR makes sure that the proxy objects returned/used by cudf.pandas work with cuxfilter.

closes #605

Authors:
  - Matthew Murray (https://github.com/Matt711)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #619
@jameslamb
Drop Python 3.9 support (#623)
b49f785 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #623
@KyleFromNVIDIA
Update rapidsai/pre-commit-hooks (#624)
ca63e9d 
This PR updates rapidsai/pre-commit-hooks to the version 0.4.0.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #624
@jameslamb
Add support for Python 3.12, drop pyppeteer dependency (#625)
53537fe 
Contributes to rapidsai/build-planning#40

This PR adds support for Python 3.12.

## Notes for Reviewers

This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.

A follow-up PR will revert back to pointing at the `branch-24.10` branch of `shared-workflows` once all
RAPIDS repos have added Python 3.12 support.

Additional changes needed to add this support:

* dropping dependency on `pyppeteer` (https://github.com/rapidsai/cuxfilter/pull/625/files#r1750741079)

### This will fail until all dependencies have been updates to Python 3.12

CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.

This can be merged whenever all CI jobs are passing.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #625
@bdice
Update to flake8 7.1.1. (#627)
6981ae6 
We need to update flake8 to fix a false-positive that appears with older flake8 versions on Python 3.12.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #627
@jameslamb
Use CI workflow branch 'branch-24.10' again [skip ci] (#629)
7736669
@bdice
Recommend miniforge for conda installation (#626)
cd699b8 
Recommending `miniforge` for conda install in installation docs.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #626
@seberg
Remove NumPy <2 pin, remove panel ceiling (#622)
516b1f0 
This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).

EDIT: Sorry, converted back to draft again, NumPy 2 is not yet picked up.

Authors:
  - Sebastian Berg (https://github.com/seberg)
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)
  - Ajay Thorve (https://github.com/AjayThorve)
  - James Lamb (https://github.com/jameslamb)

URL: #622
@AyodeAwe
update update-version.sh to use packaging lib (#631)
58238a5
@galipremsagar
Switch traceback to native in pytest (#633)
0cd1568 
In cudf & cuml we have observed a ~10% to ~20% respectively speed up of pytest suite execution by switching pytest traceback to `--native`:

```
currently:

102474 passed, 2117 skipped, 902 xfailed in 892.16s (0:14:52)

--tb=short:

102474 passed, 2117 skipped, 902 xfailed in 898.99s (0:14:58)

--tb=no:

102474 passed, 2117 skipped, 902 xfailed in 815.98s (0:13:35)

--tb=native:

102474 passed, 2117 skipped, 902 xfailed in 820.92s (0:13:40)
```

This PR makes a similar change to `cuxfilter` repo.

xref: rapidsai/cudf#16851

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ajay Thorve (https://github.com/AjayThorve)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #633
@raydouglass raydouglass requested review from a team as code owners October 4, 2024 19:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 25.87%. Comparing base (0e64ef6) to head (0cd1568).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
.../cuxfilter/charts/core/non_aggregate/core_graph.py 0.00% 7 Missing ⚠️
python/cuxfilter/charts/core/core_chart.py 0.00% 3 Missing ⚠️
...ter/charts/core/non_aggregate/core_stacked_line.py 0.00% 2 Missing ⚠️
python/cuxfilter/charts/datashader/plots.py 0.00% 2 Missing ⚠️
python/cuxfilter/charts/panel_widgets/plots.py 0.00% 2 Missing ⚠️
python/cuxfilter/charts/bokeh/plots/bar.py 0.00% 1 Missing ⚠️
...tashader/custom_extensions/holoviews_datashader.py 0.00% 1 Missing ⚠️
python/cuxfilter/dashboard.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   25.94%   25.87%   -0.08%     
==========================================
  Files          77       77              
  Lines        3781     3788       +7     
==========================================
- Hits          981      980       -1     
- Misses       2800     2808       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raydouglass raydouglass merged commit a9afff0 into main Oct 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
ci conda doc Documentation Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.