Forward-merge branch-24.10 into branch-24.12 #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![rapids-bot[bot]](https://avatars.githubusercontent.com/in/85914?s=60&v=4){kind=small}
Adds Vamana (DiskANN index construction support. Includes all files and changes to expose the vamana graph index in the C++ API, **build** and **serialize** operations only. Build runs the iterative Vamana index construction, and serialize writes the graph to a file that matches the format of the Microsoft DiskANN library. This lets users use cuVS for index construction while still doing search with their current infrastructure. Search support to be added at a later time. Some items missing / not included in the PR: - Documentation - Python and C API support - Tests that verify recall (can't do this without search) - Additional distance metrics (only L2 currently) Current known issues / bugs: - Odd dimension datasets not supported (causes alignment error) - Memory footprint is still large, need some batching / alg changes to improve - Adding a more sophisticated medoid selection (minor recall benefit) - Improving shared memory usage for high-degree construction should improve perf Authors: - Ben Karsin (https://github.com/bkarsin) - Tarang Jain (https://github.com/tarang-jain) - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) - Tarang Jain (https://github.com/tarang-jain) URL: #339
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to branch-24.10 that creates a PR to keep branch-24.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.