-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove NCCL pins in build and test environments #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cuvs use nccl directly, or only transitively via raft? I notice that it's not specified in the nccl recipes, and if I search the repo I don't see other references which makes me think it's just via raft. If so, we should just drop it here.
I searched around and it seems like it's only used transitively through raft. git grep -i nccl Looked through the diff of #231 too, and I only see stuff like this: const raft::comms::nccl_clique& clique = handle.get_nccl_clique_handle(); |
Yeah that matches my expectation. Let's see if tests pass. If they do, please update the title and description accordingly and I can approve. |
Tests look happy! I've updated the title and description here. Thanks for the nudge, removing these pins will make the next such update a little easier 😁 |
/merge |
Thanks all! 🙏 |
Description
Contributes to rapidsai/build-planning#102
Some RAPIDS libraries are using
ncclCommSplit()
, which was introduced innccl==2.18.1.1
. This is part of a series of PRs across RAPIDS updating libraries' pins tonccl>=2.18.1.1
to ensure they get a new-enough version that supports that.cuvs
doesn't have any direct uses of NCCL... it only uses it via raft. This PR proposes removingcuvs
's dependency pinnings on NCCL, in favor of just using whatever it gets transitively via raft.