Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix library-loading issues in editable installs #1484

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 15, 2024

Description

Contributes to rapidsai/build-planning#118

The pattern introduced in #1483 breaks editable installs in devcontainers. In that type of build, libcuspatial.so is built outside of the wheel but not installed, so it can't be found by ld. Extension modules in cuspatial are able to find it via RPATHs instead.

This proposes:

  • try-catching the entire library-loading attempt, to silently do nothing in cases like that
  • adding an import of the cuspatial Python library in the devcontainers CI job, as a smoke test to catch issues like this in the future (edit: removed those, devcontainer builds run on CPU nodes)

Notes for Reviewers

How I tested this

Tested this approach on rapidsai/kvikio#553

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added bug Something isn't working non-breaking Non-breaking change labels Nov 15, 2024
@github-actions github-actions bot added the Python Related to Python code label Nov 15, 2024
@jameslamb jameslamb changed the title WIP: fix library-loading issues in editable installs fix library-loading issues in editable installs Nov 15, 2024
@jameslamb jameslamb requested a review from vyasr November 15, 2024 19:20
@jameslamb jameslamb marked this pull request as ready for review November 15, 2024 19:20
@jameslamb jameslamb requested a review from a team as a code owner November 15, 2024 19:20
@jameslamb jameslamb requested a review from thomcom November 15, 2024 19:20
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 0a79456 into rapidsai:branch-24.12 Nov 15, 2024
70 checks passed
@jameslamb jameslamb deleted the fix-library-loading branch November 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants