Pin proj to 9.3.0 in cuproj
#1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Approve. I think this will help fix the issue. We typically have been pinning with proj_version in conda_build_config.yaml and {{ proj_version }} in meta.yaml to make it clear that we have a pin for readers of meta.yaml -- but this PR's changes are functionally equivalent.
harrism
approved these changes
Dec 7, 2023
raydouglass
approved these changes
Dec 7, 2023
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
Proposes removing the `cuproj` conda package's pin on `proj`, so that it can build using the same version that `conda-forge` pins to in https://github.com/conda-forge/conda-forge-pinning-feedstock. For context, see: * why the `proj==9.3.0` pin was originally added: #1307 * `conda-forge` completied migrations: - `9.3.1`: conda-forge/conda-forge-pinning-feedstock#5401 - `9.4.`: conda-forge/conda-forge-pinning-feedstock#6240 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham URL: #1449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
pyprojis still pinned toproj9.3.0 (for example). Howeverprojrecently released9.3.1( conda-forge/proj.4-feedstock#140 ), whichcuprojis pulling in at the moment. Sinceprojpins to the patch version in itsrun_exports, building against9.3.1meanscuprojwould need exactly9.3.1at runtime. This makes it incompatible with everything else, which is still pinned toproj9.3.0. Embedded screenshot below to highlight thisSo for now just manually pin
projto9.3.0to buildcuprojwith a consistentprojversion to resolve conflictsThis issue should clear up once to
proj9.3.1migration ( conda-forge/conda-forge-pinning-feedstock#5226 ) completes. Then we can bump this or drop it as we see fit thenChecklist