Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] cuspatial v23.10 #1280

Merged
merged 33 commits into from
Oct 11, 2023
Merged

[RELEASE] cuspatial v23.10 #1280

merged 33 commits into from
Oct 11, 2023

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-23.10 and v23.10 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-23.10 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-23.10 into main for the release

raydouglass and others added 30 commits July 21, 2023 10:04
@raydouglass
v23.10 Updates [skip ci]
8d88bed
@GPUtester
Merge pull request #1226 from rapidsai/branch-23.08
f5fc894 
Forward-merge branch-23.08 to branch-23.10
@GPUtester
Merge pull request #1228 from rapidsai/branch-23.08
8f907d2 
Forward-merge branch-23.08 to branch-23.10
@vyasr
Merge branch 'branch-23.08' into branch-23.10-merge-23.08
bbca8f9
@ajschmidt8
Merge pull request #1230 from vyasr/branch-23.10-merge-23.08
bd3085c 
Branch 23.10 merge 23.08
@GPUtester
Merge pull request #1236 from rapidsai/branch-23.08
8d6ca40 
Forward-merge branch-23.08 to branch-23.10
@GPUtester
Merge pull request #1240 from rapidsai/branch-23.08
742b6b3 
Forward-merge branch-23.08 to branch-23.10
@GPUtester
Merge pull request #1241 from rapidsai/branch-23.08
7a50764 
Forward-merge branch-23.08 to branch-23.10
@thomcom
Merge branch 'branch-23.08' into branch-23.10
701bd12
@thomcom
All 23.10 version updates?
278de03
@thomcom
Remove cuspatial=23.10 dependency from cuproj.
8177367
@thomcom
Remove cuspatial from pyproject.toml as well
48b3406
@thomcom
Drop cuspatial from cuproj test.
19fff38
@vyasr
Update to Cython 3.0.0 (#1235)
52238a0 
The cuspatial Python code appears to need no updates to build without warnings (with the exception of upstream cuda-python issues that we expect to be fixed in an upcoming release).

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Michael Wang (https://github.com/isVoid)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #1235
@thomcom
Merge branch 'branch-23.10' into bug/fix-23.08-23.10-automerge
9d50b2f
@ajschmidt8
Merge pull request #1251 from thomcom/bug/fix-23.08-23.10-automerge
fb963ff 
Fix 23.08 -> 23.10 automerge
@GPUtester
Merge pull request #1254 from rapidsai/branch-23.08
456ebeb 
Forward-merge branch-23.08 to branch-23.10
@thomcom
Change path to trajectories_extracted.p to improve CI run consistency. (
4220ab1 
#1247)

Changes the URL to `trajectories_extracted.p` to a `data.rapids.ai` url, which should improve CI run stability for notebooks. @taureandyernv

Authors:
  - H. Thomson Comer (https://github.com/thomcom)
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: #1247
@GPUtester
Merge pull request #1257 from rapidsai/branch-23.08
3007d88 
Forward-merge branch-23.08 to branch-23.10
@harrism
Add back deleted conda env files (#1261)
88ee1bb 
The yaml files in conda/environments were accidentally deleted in #1251 . This PR adds them back.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #1261
@ajschmidt8
Use copy-pr-bot (#1262)
7237565 
This PR replaces the `copy_prs` functionality from the `ops-bot` with the new dedicated `copy-pr-bot` GitHub application.

Thorough documentation for the new `copy-pr-bot` application can be viewed below.

- https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/

**Important**: `copy-pr-bot` enforces signed commits. If an organization member opens a PR that contains unsigned commits, it will be deemed untrusted and therefore require an `/ok to test` comment. See the GitHub docs [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) for information on how to set up commit signing.

Any time a PR is deemed untrusted, it will receive a comment that looks like this: rapidsai/ci-imgs#63 (comment).

Every subsequent commit on an untrusted PR will require an additional `/ok to test` comment.

Any existing PRs that have unsigned commits after this change is merged will require an `/ok to test` comment for each subsequent commit _or_ the PR can be rebased to include signed commits as mentioned in the docs below:
https://docs.gha-runners.nvidia.com/cpr/contributors.

This information is all included on the documentation page linked above.

_I've skipped CI on this PR since it's not a change that is tested._

[skip ci]
@taureandyernv
[REVIEW] Add cudf example code for haversine distance into 23.10 (#1260)
a87d21f 
Authors:
  - Taurean Dyer (https://github.com/taureandyernv)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Mark Harris (https://github.com/harrism)

URL: #1260
@bdice
Use conda mambabuild not mamba mambabuild (#1265)
56f7cfc 
With the release of conda 23.7.3, `mamba mambabuild` stopped working. With boa installed, `conda mambabuild` uses the mamba solver, so just use that instead.

See also rapidsai/cudf#14068.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1265
@divyegala
Simplify wheel build scripts and allow alphas of RAPIDS dependencies (#…
a8adea4 
…1264)

This PR:

1. Removes `ci/apply_wheel_modifications.sh` and uses it inline in wheel build scripts
2. Allows for specifying alpha versioned dependencies of RAPIDS projects

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1264
@bdice
Update to clang 16.0.6. (#1266)
7f14fb2 
This PR updates cuspatial to use clang 16.0.6. This aligns with the major version 16 being used elsewhere in RAPIDS, with a bugfix version that avoids clang-format issues around `*` multiplication operators.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1266
@AyodeAwe
Update image names (#1269)
b063e08 
PR updates `rapidsai/ci` references to `rapidsai/ci-conda`

Authors:
  - Jake Awe (https://github.com/AyodeAwe)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1269
@trxcllnt
Update devcontainers to align with other RAPIDS repositories (#1263)
73412e6 
Removes the unified and isolated devcontainers in favor of just the single one. The unified devcontainers are [still available](https://github.com/rapidsai/devcontainers/blob/d970ac17a894f5d1047fcfd17cffa6d14fe66ec8/.devcontainer/cuda12.0-conda/devcontainer.json#L23-L31) in the [`rapidsai/devcontainers`](https://github.com/rapidsai/devcontainers) repository.


Adds an optional job to the `pr.yaml` to [build the cuGraph libs in each devcontainer](https://github.com/trxcllnt/cuspatial/blob/fea/devcontainers/.github/workflows/pr.yaml#L106-L111), so the build caches are populated for devs by CI.

Other PRs:

* rapidsai/rmm#1328
* rapidsai/kvikio#273
* rapidsai/cudf#14015
* rapidsai/raft#1791
* rapidsai/cumlprims_mg#149
* rapidsai/cuml#5568
* rapidsai/cugraph-ops#538
* rapidsai/cugraph#3838

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1263
@trxcllnt
fix update-version.sh (#1272)
6ebb3b7 
Fixes copy/paste errors in #1263.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1272
@thomcom
Add binary_predicates.ipynb workflow and test data to package. (#1258)
73e2df7 
A missing package in this notebook is required in order for it to be usable with 23.08.

Authors:
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1258
@isVoid
Benchmark GeoSeries.Distance (#1277)
366183c 
closes #994 
There are primitive benchmark results for `GeoSeries.distance` in #1231. This PR plans to add more benchmark coverage:
TODO:
- [x] point-point
- [x] point-linestring
- [x] point-polygon
- [x] linestring-linestring
- [x] linestring-polygon
- [x] polygon-polygon
- [x] Geometry complexity dimension
- [x] Geometry spatial relationship dimension
- [ ] Write the blog

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1277
@thomcom
Re-enable cuspatial tests and dependency. (#1253)
6c9ac11 
A poorly understood cuproj->cuspatial dependency required that cuspatial be removed from cuproj's tests during the 23.08->23.10 merge rebase. This PR re-enables those tests.

Authors:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1253
@raydouglass raydouglass requested review from a team as code owners October 6, 2023 18:53
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 6, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added conda Related to conda and conda configuration cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library ci labels Oct 6, 2023
raydouglass and others added 2 commits October 10, 2023 14:01
@raydouglass
Add curl for notebook testing (#1281)
32d908f 
Adds `curl` as a notebook dependency which is used in two notebooks: `notebooks/nyc_taxi_years_correlation.ipynb` & `notebooks/ZipCodes_Stops_PiP_cuSpatial.ipynb` (https://github.com/search?q=repo%3Arapidsai%2Fcuspatial+curl&type=code).

This is similar to rapidsai/cugraph#3918 and will fix errors in the notebooks tests in `rapidsai/docker`.

Authors:
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - AJ Schmidt (https://github.com/ajschmidt8)
@raydouglass
Update Changelog [skip ci]
38bad5c
@raydouglass raydouglass merged commit 8701668 into main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
ci cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.