make conda installs in CI stricter #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
jameslamb
changed the title
jameslamb
added
3 - Ready for Review
bdice
approved these changes
Oct 9, 2024
dantegd
approved these changes
Oct 10, 2024
|
/merge |
|
Apologies for merging too soon @jameslamb, saw Bradley's approval and was happy to get it in asap :) |
|
No prob, my fault for not making it back here fast enough 😂 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
Follow-up to #6103. In that PR, I'd removed the `export RAPIDS_MAJOR_MINOR_VERSION`. I realized that this project's Doxygen setup actually expects that to be set in the environment. https://github.com/rapidsai/cuml/blob/22342aad0ecd327e3140471c479d01d83b932c23/ci/build_docs.sh#L35 https://github.com/rapidsai/cuml/blob/22342aad0ecd327e3140471c479d01d83b932c23/cpp/Doxyfile.in#L41 This fixes that, sorry 😬 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham - Mike Sarahan (https://github.com/msarahan) URL: #6104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#106
Proposes specifying the RAPIDS version in
conda installcalls that install CI artifacts, to reduce the risk of CI jobs picking up artifacts from other releases.Notes for Reviewers
This only changes the docs build, because other packages already solve in a single
conda installwith version constraints, thanks to #5781.