Add support to create temporal graphs #4819
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
seunghwak
reviewed
Dec 10, 2024
| @@ -33,6 +36,7 @@ namespace detail { | |||
| * @tparam edge_t Type of edge identifiers. Needs to be an integral type. | |||
| * @tparam weight_t Type of edge weights. Needs to be a floating point type. | |||
| * @tparam edge_type_t Type of edge type identifiers. Needs to be an integral type. | |||
| * @tparam edge_time_t The type of the edge time stamp | |||
There was a problem hiding this comment.
Inconsistent with the documentation below.
@tparam edge_time_t Type of edge time. Needs to be an integral type.
Should this be the integral type as well?
| @@ -82,27 +97,37 @@ shuffle_ext_vertex_pairs_with_values_to_local_gpu_by_edge_partitioning( | |||
| * @param[in] weights Optional vector of vertex pair weight values. | |||
| * @param[in] edge_ids Optional vector of vertex pair edge id values. | |||
| * @param[in] edge_types Optional vector of vertex pair edge type values. | |||
| * @param[in] edge_start_times Optional vector of vertex pair start time values. | |||
| * @param[in] edge_end_times Optional vector of vertex pair end time values. | |||
There was a problem hiding this comment.
Inconsistent with the documentation above.
* @param[in] edge_start_times Optional vector of vertex pair edge start time values.
* @param[in] edge_end_times Optional vector of vertex pair edge end time values.
Should this better be "vetex pair edge start/end time values'' for consistency?
| @@ -220,7 +245,10 @@ shuffle_int_vertex_value_pairs_to_local_gpu_by_vertex_partitioning( | |||
| * @param[in,out] d_edgelist_minors Vertex IDs for destinations (if we are internally storing edges | |||
| * in the sparse 2D matrix using sources as major indices) or sources (otherwise) | |||
| * @param[in,out] d_edgelist_weights Optional edge weights | |||
There was a problem hiding this comment.
Documentation missing for edge_t, edge_type_t & edge_time_t.
| @@ -406,14 +406,27 @@ decompress_to_edgelist( | |||
| * std::optional<rmm::device_uvector<weight_t>>> Tuple of symmetrized sources, destinations, and | |||
| * optional weights (if @p edgelist_weights is valid). | |||
| */ | |||
There was a problem hiding this comment.
Documentation needs updates.
| * @tparam edge_t Type of edge identifiers. Needs to be an integral type. | ||
| * @tparam weight_t Type of edge weight. Needs to be floating point type | ||
| * @tparam edge_type_t Type of edge type. Needs to be an integral type, currently only int32_t is | ||
| * supported |
There was a problem hiding this comment.
Documentation missing for edge_time_t.
| static_cast<size_t>(thrust::distance(lower_triangular_last, diagonal_last)); | ||
| } | ||
|
|
||
| if (edgelist_edge_ids) { |
| edgelist_weights->begin(), | ||
| tmp.begin()); | ||
|
|
||
| thrust::copy(handle.get_thrust_policy(), tmp.begin(), tmp.end(), edgelist_weights->begin()); |
| num_lower_triangular_edges, | ||
| reciprocal); | ||
| } | ||
| if (edgelist_edge_ids) { |
| mem_frugal_threshold, | ||
| handle.get_stream()); | ||
| } | ||
|
|
||
| if (edge_ids) { |
| weights->begin(), | ||
| tmp.begin()); | ||
|
|
||
| thrust::copy(handle.get_thrust_policy(), tmp.begin(), tmp.end(), weights->begin()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two optional edge properties (
edge_start_timesandedge_end_times) that can be used to represent times when edges are active in the graph. This will support providing views of the graph at a particular time, or using edge times to control traversal in a reasonable time order.This PR is still awaiting C++ unit tests for temporal graphs, but the logic is fully implemented.
Marked as breaking. Most of the old APIs are still supported, but since I updated all of the tests to use the new APIs, we don't actually test the old APIs.