remove 'wget' conda dependency, re-organize dependencies.yaml #4805
+51
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
2 tasks
|
Tests here are failing like this: Documented that in #4823 ... there are some changes in |
|
/ok to test |
|
Oh great thanks for merging |
|
/ok to test |
jameslamb
changed the title
|
/ok to test |
jameslamb
changed the title
bdice
approved these changes
Dec 19, 2024
| @@ -565,6 +562,31 @@ dependencies: | |||
| - pylibwholegraph-cu11==25.2.*,>=0.0.0a0 | |||
| - {matrix: null, packages: [*pylibwholegraph_unsuffixed]} | |||
|
|
|||
| depends_on_librmm: | |||
There was a problem hiding this comment.
We probably want the same for other packages too? libcudf, libraft? It’s okay to defer on this in the name of gradual improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4804, I've started working on adding
libcugraphwheels.This includes a few fixes for things I noticed while doing that:
wgetfromtest_notebookenvironmentdependencies.yamlre-organization:librmmdependency out into adepends_on_librmmto reduce duplication, and for consistency with other RAPIDS dependenciesdepends_on_pylibwholegraphgroup everywhere instead of repeatingpylibwholegraphin multiple placesNotes for Reviewers
I'd originally wanted to also add a
librmmwheel dependency for wheel builds here, but looks like doing that resulted in a lot moresccachemisses, I guess because of building with build isolation. That change will happen in #4804 .