Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.12 into branch-25.02 #4802

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Dec 4, 2024

Forward-merge triggered by push to branch-24.12 that creates a PR to keep branch-25.02 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

…4799)

We are planning to migrate to CCCL 2.7.0 in RAPIDS 25.02. I found a compilation error in `libcugraph_etl` that is fixed by removing a reference `&` from a device comparator, and passing the parameters by value instead.

This is a pretty small fix but I expect we will want to build 24.12 with newer CCCL versions for DLFW releases. To avoid needing a backport for DLFW, I am targeting 24.12 with this change. I can retarget to 25.02 if desired.

This is extracted from #4743, but that PR shouldn't be merged (it includes testing changes that are not intended for merge).

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #4799
@rapids-bot rapids-bot bot requested a review from a team as a code owner December 4, 2024 16:17
@GPUtester GPUtester merged commit 5bc4cda into branch-25.02 Dec 4, 2024
Copy link
Author

rapids-bot bot commented Dec 4, 2024

SUCCESS - forward-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants