Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug build failure #4774

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Nov 19, 2024

cugraph is no longer dependent on cugraph_ops and no longer pulls files from the cugrpahops repo. But we have two assert statements still assuming cugrpahops files are available. These assert statements are compiled only in the debug mode. This PR fixes build errors due to these assert statements in the debug build.

Closes #4763

@seunghwak seunghwak self-assigned this Nov 19, 2024
@seunghwak seunghwak requested a review from a team as a code owner November 19, 2024 21:28
@seunghwak seunghwak linked an issue Nov 19, 2024 that may be closed by this pull request
2 tasks
@seunghwak seunghwak added this to the 24.12 milestone Nov 19, 2024
@seunghwak seunghwak added bug Something isn't working non-breaking Non-breaking change labels Nov 19, 2024
@@ -1568,9 +1566,6 @@ uniform_sample_and_compute_local_nbr_indices(
bool with_replacement)
{
using edge_t = typename GraphViewType::edge_type;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line's now failing a style check. It wants the = signs aligned without the intervening lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran clang-format.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit a977755 into rapidsai:branch-24.12 Nov 25, 2024
73 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuGraph non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QST]: Building from source errors
3 participants