Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook to run Centrality against PatentsView data for Medium Blog #4769

Merged
merged 15 commits into from
Dec 2, 2024
Merged

Notebook to run Centrality against PatentsView data for Medium Blog #4769

merged 15 commits into from
Dec 2, 2024

Conversation

acostadon
Copy link
Contributor

No description provided.

@acostadon acostadon added doc Documentation non-breaking Non-breaking change Notebook labels Nov 18, 2024
@acostadon acostadon added this to the 24.12 milestone Nov 18, 2024
@acostadon acostadon self-assigned this Nov 18, 2024
@acostadon acostadon requested a review from a team as a code owner November 18, 2024 00:38
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@BradReesWork
Copy link
Member

Cell 1: please add text with license of dataset an steps for downloading and expanding
After cell 2 - add a new header - otherwise it looks like everything is related to downloading data
Cell 3: move the comment into the cell
Cell 13: I don't understand why you get the 2nd, 3rd, and 4th hops

You need more discriptive text bout what is going on

BradReesWork
BradReesWork requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cell 1: please add text with license of dataset an steps for downloading and expanding
After cell 2 - add a new header - otherwise it looks like everything is related to downloading data
Cell 3: move the comment into the cell
Cell 13: I don't understand why you get the 2nd, 3rd, and 4th hops

You need more discriptive text bout what is going on

jnke2016
jnke2016 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

@acostadon acostadon requested a review from jnke2016 November 21, 2024 16:26
@acostadon acostadon requested a review from jnke2016 November 21, 2024 20:00
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 8035bb5 into rapidsai:branch-24.12 Dec 2, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@acostadon acostadon

Labels
doc Documentation non-breaking Non-breaking change Notebook python
Projects
None yet
Milestone
24.12
Development

Successfully merging this pull request may close these issues.
3 participants
@acostadon @BradReesWork @jnke2016