Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nx-cugraph from this repo #4756

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Nov 13, 2024

This is part of the migration to https://github.com/rapidsai/nx-cugraph

This is meant to fully remove nx-cugraph except for docs, which are still built from this repo.

CC @nv-rliu @jameslamb @rlratzel

This is part of the migration to https://github.com/rapidsai/nx-cugraph

This is meant to fully remove nx-cugraph *except* for docs,
which are still built from this repo.
@eriknw eriknw requested review from a team as code owners November 13, 2024 19:17
@eriknw eriknw requested a review from jameslamb November 13, 2024 19:17
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@eriknw
Copy link
Contributor Author

eriknw commented Nov 13, 2024

Note that I changed some links in the README and a couple of the docs.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I searched this branch like this:

git grep -i nx

Found just one other thing that probably could now be removed:

cugraph/ci/test_wheel.sh

Lines 26 to 28 in a5fdc8b

# FIXME: Adding PY_IGNORE_IMPORTMISMATCH=1 to workaround conftest.py import
# mismatch error seen by nx-cugraph after using pytest 8 and
# --import-mode=append.

Do whatever you want with that.

Marking this "Approve" because otherwise everything here looks great to me!

@eriknw
Copy link
Contributor Author

eriknw commented Nov 14, 2024

Thanks! I searched this branch like this:

git grep -i nx

Found just one other thing that probably could now be removed:

cugraph/ci/test_wheel.sh

Lines 26 to 28 in a5fdc8b

# FIXME: Adding PY_IGNORE_IMPORTMISMATCH=1 to workaround conftest.py import
# mismatch error seen by nx-cugraph after using pytest 8 and
# --import-mode=append.

Do whatever you want with that.

Ha, I left a similar comment here: #4748 (review)

I think we can try removing it once we get CI to pass, which I think will need rapidsai/devcontainers#417 or rapidsai/devcontainers#418

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 14, 2024
jameslamb pushed a commit to rapidsai/devcontainers that referenced this pull request Nov 15, 2024
I believe this is needed to remove `nx-cugraph` from the `cugraph` repo
being done in rapidsai/cugraph#4756

This is a subset of the changes @jameslamb is making in
#417. Does it make sense
to do this change for `nx-cugraph` and `cugraph-gnn` independently (how
close is `cugraph-gnn` to being removed?)? Should we also add
`nx-cugraph` as done in that PR? Anything else?

@nv-rliu @jameslamb @rlratzel
@eriknw
Copy link
Contributor Author

eriknw commented Nov 16, 2024

This PR is passing CI and has been approved. Who would like to do the honors of merging?

@KyleFromNVIDIA
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 66d1324 into rapidsai:branch-24.12 Nov 18, 2024
86 of 95 checks passed
BradReesWork pushed a commit to BradReesWork/cugraph that referenced this pull request Nov 18, 2024
This is part of the migration to https://github.com/rapidsai/nx-cugraph

This is meant to fully remove nx-cugraph *except* for docs, which are still built from this repo.

CC @nv-rliu @jameslamb @rlratzel

Authors:
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#4756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants