-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nx-cugraph
from this repo
#4756
Conversation
This is part of the migration to https://github.com/rapidsai/nx-cugraph This is meant to fully remove nx-cugraph *except* for docs, which are still built from this repo.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Note that I changed some links in the README and a couple of the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I searched this branch like this:
git grep -i nx
Found just one other thing that probably could now be removed:
Lines 26 to 28 in a5fdc8b
# FIXME: Adding PY_IGNORE_IMPORTMISMATCH=1 to workaround conftest.py import | |
# mismatch error seen by nx-cugraph after using pytest 8 and | |
# --import-mode=append. |
Do whatever you want with that.
Marking this "Approve" because otherwise everything here looks great to me!
Ha, I left a similar comment here: #4748 (review) I think we can try removing it once we get CI to pass, which I think will need rapidsai/devcontainers#417 or rapidsai/devcontainers#418 |
use `#supported-algorithms`, not `#algorithms`
I believe this is needed to remove `nx-cugraph` from the `cugraph` repo being done in rapidsai/cugraph#4756 This is a subset of the changes @jameslamb is making in #417. Does it make sense to do this change for `nx-cugraph` and `cugraph-gnn` independently (how close is `cugraph-gnn` to being removed?)? Should we also add `nx-cugraph` as done in that PR? Anything else? @nv-rliu @jameslamb @rlratzel
This PR is passing CI and has been approved. Who would like to do the honors of merging? |
/merge |
This is part of the migration to https://github.com/rapidsai/nx-cugraph This is meant to fully remove nx-cugraph *except* for docs, which are still built from this repo. CC @nv-rliu @jameslamb @rlratzel Authors: - Erik Welch (https://github.com/eriknw) Approvers: - James Lamb (https://github.com/jameslamb) - Brad Rees (https://github.com/BradReesWork) URL: rapidsai#4756
This is part of the migration to https://github.com/rapidsai/nx-cugraph
This is meant to fully remove nx-cugraph except for docs, which are still built from this repo.
CC @nv-rliu @jameslamb @rlratzel