extract the edgelist from the graph #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnke2016
changed the title
rlratzel
reviewed
Nov 15, 2024
python/cugraph/cugraph/structure/graph_implementation/simpleDistributedGraph.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/structure/graph_implementation/simpleDistributedGraph.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/structure/graph_implementation/simpleDistributedGraph.py
Show resolved
Hide resolved
…2_expose-decompress-to-edgelist
rlratzel
approved these changes
Nov 19, 2024
seunghwak
reviewed
Nov 19, 2024
| cugraph_error_code_t cugraph_decompress_to_edgelist(const cugraph_resource_handle_t* handle, | ||
| cugraph_graph_t* graph, | ||
| bool_t do_expensive_check, | ||
| cugraph_induced_subgraph_result_t** result, |
There was a problem hiding this comment.
Just a suggestion, but cugraph_induced_subgraph_result_t sounds a bit of misnomer here. We may used this data structure to just store edge list from the induced subgraph algorithm in the past, but if we wish to use this for other algorithms as well, we may better rename this now or sometime in the future.
There was a problem hiding this comment.
Agreed. I would suggest cugraph_edgelist_t. I have a draft PR (that I need to discard and start over with) that was going to create a cugraph_edgelist_t for the C API for graph construction.
I'd suggest the following:
- Replicate the
cugraph_induced_subgraph_result_ttype and C API accessor functions to call itcugraph_edgelist_tinstead - Mark the induced subgraph variations as deprecated
- Within the C API implementation (
src/c_api) you can either rename thecugraph::c_api::cugraph_induced_subgraph_result_ttocugraph::c_api::cugraph_edgelist_tand rename all references accordingly, or you can leave it using the legacy version and I'll fix it in 25.02 when I finish the C API graph construction updates.
| transpose_storage<vertex_t, edge_t, weight_t, store_transposed, multi_gpu>( | ||
| handle_, graph_, error_.get()); | ||
| if (error_code_ != CUGRAPH_SUCCESS) | ||
| ; |
ChuckHastings
approved these changes
Nov 20, 2024
seunghwak
approved these changes
Nov 21, 2024
rlratzel
added
improvement
…2_expose-decompress-to-edgelist
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the C++ function decompress_to_edgelist to the C, PLC and Python API. This will enable the extraction of the edgelist from a graph which is currently not supported. It also removes the deprecated parameter
legacy_renum_only