Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nx-cugraph introduction notebook to repo #4677

Merged
merged 16 commits into from
Oct 3, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Sep 27, 2024

Proposed Changes

This PR adds an introduction notebook to the notebooks/demo directory of the repository. Click the link to view the files directory in the dev branch.

@nv-rliu nv-rliu added non-breaking Non-breaking change Notebook labels Sep 27, 2024
@nv-rliu nv-rliu added this to the 24.10 milestone Sep 27, 2024
@nv-rliu nv-rliu requested a review from rlratzel September 27, 2024 13:54
@nv-rliu nv-rliu self-assigned this Sep 27, 2024
@nv-rliu nv-rliu requested a review from a team as a code owner September 27, 2024 13:54
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nv-rliu nv-rliu added benchmarks feature request New feature or request and removed benchmarks labels Sep 27, 2024
@rlratzel rlratzel requested a review from eriknw September 30, 2024 16:58
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are great! I suggested a fix for a couple typos, and left a couple minor questions or nits. The only thing blocking approval is the "TODO" remaining in a notebook.

notebooks/demo/accelerating_networkx.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nxcg_wikipedia_e2e.ipynb Outdated Show resolved Hide resolved
notebooks/demo/accelerating_networkx.ipynb Show resolved Hide resolved
notebooks/demo/accelerating_networkx.ipynb Show resolved Hide resolved
notebooks/demo/accelerating_networkx.ipynb Outdated Show resolved Hide resolved
@nv-rliu nv-rliu requested a review from eriknw October 1, 2024 15:45
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there... a couple minor nits.

notebooks/demo/accelerating_networkx.ipynb Outdated Show resolved Hide resolved
notebooks/demo/accelerating_networkx.ipynb Show resolved Hide resolved
notebooks/demo/accelerating_networkx.ipynb Show resolved Hide resolved
@nv-rliu nv-rliu requested a review from eriknw October 1, 2024 22:50
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great..only 2 recommendations, neither of which should delay merging.

  1. I commented on adding the link to the NetworkX config package.
    https://networkx.org/documentation/stable/reference/backends.html#module-networkx.utils.configs

  2. It would be nice to have a link to to documentation of the wikipedia dataset. I looked but couldn't find it. It would enable users to experiment with the notebook.

notebooks/demo/accelerating_networkx.ipynb Show resolved Hide resolved
@rlratzel rlratzel changed the title Add nx-cugraph notebooks to repo Add nx-cugraph introduction notebook to repo Oct 2, 2024
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's too bad it's not using new NX 3.4 features, but this way it'll work with old and new versions.

@BradReesWork
Copy link
Member

/merge

@AyodeAwe AyodeAwe merged commit f8b9ac3 into rapidsai:branch-24.10 Oct 3, 2024
129 of 131 checks passed
@nv-rliu nv-rliu deleted the nxcg-notebooks branch October 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Notebook python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants