-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nx-cugraph
introduction notebook to repo
#4677
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…nto nxcg-notebooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are great! I suggested a fix for a couple typos, and left a couple minor questions or nits. The only thing blocking approval is the "TODO" remaining in a notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there... a couple minor nits.
Co-authored-by: Erik Welch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great..only 2 recommendations, neither of which should delay merging.
-
I commented on adding the link to the NetworkX config package.
https://networkx.org/documentation/stable/reference/backends.html#module-networkx.utils.configs -
It would be nice to have a link to to documentation of the wikipedia dataset. I looked but couldn't find it. It would enable users to experiment with the notebook.
nx-cugraph
notebooks to reponx-cugraph
introduction notebook to repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It's too bad it's not using new NX 3.4 features, but this way it'll work with old and new versions.
/merge |
Proposed Changes
This PR adds an introduction notebook to the
notebooks/demo
directory of the repository. Click the link to view the files directory in the dev branch.nx-cugraph
notebook