Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump NCCL floor to 2.18.1.1, include nccl.h where it's needed #4661

Merged
merged 2 commits into from
Sep 25, 2024
Merged

bump NCCL floor to 2.18.1.1, include nccl.h where it's needed #4661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7346c
bump NCCL floor to 2.18.1.1
jameslamb Sep 20, 2024
7fca13f
include nccl.h directly where NCCL functions are used
jameslamb Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies:
- libraft==24.10.*,>=0.0.0a0
- librmm==24.10.*,>=0.0.0a0
- nbsphinx
- nccl>=2.9.9
- nccl>=2.18.1.1
- networkx>=2.5.1
- networkx>=3.0
- ninja
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-125_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dependencies:
- libraft==24.10.*,>=0.0.0a0
- librmm==24.10.*,>=0.0.0a0
- nbsphinx
- nccl>=2.9.9
- nccl>=2.18.1.1
- networkx>=2.5.1
- networkx>=3.0
- ninja
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/libcugraph/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ doxygen_version:
- ">=1.8.11"

nccl_version:
- ">=2.9.9"
- ">=2.18.1.1"

c_stdlib:
- sysroot
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cugraph/mtmg/instance_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

#include <raft/comms/std_comms.hpp>

#include <nccl.h>

#include <vector>

namespace cugraph {
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cugraph/mtmg/resource_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
#include <rmm/mr/device/owning_wrapper.hpp>
#include <rmm/mr/device/pool_memory_resource.hpp>

#include <nccl.h>

#include <execution>

namespace cugraph {
Expand Down
1 change: 1 addition & 0 deletions cpp/tests/mtmg/multi_node_threaded_test.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include <thrust/unique.h>

#include <gtest/gtest.h>
#include <nccl.h>

#include <filesystem>
#include <fstream>
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ dependencies:
- aiohttp
- fsspec>=0.6.0
- requests
- nccl>=2.9.9
- nccl>=2.18.1.1
- ucx-proc=*=gpu
- &ucx_py_unsuffixed ucx-py==0.40.*,>=0.0.0a0
- output_types: pyproject
Expand Down
Loading