Remove NumPy <2 pin #4657
Closed
Remove NumPy <2 pin #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rapidsaigh-4486 for adding torchdata/pydantic and rapidsaigh-4464 for introducing the torch pin due to NCCL difficulties. It is entirely possible that this still fails due to the NCCL issue!
… IDs (as required).
hcho3
added
improvement
|
Hey @hcho3 thanks for working on this! Would you consider continuing this work by just pushing to #4615 instead? That way, all the prior discussion about the code changes would be in the same place as the changes themselves. Now that you have write access to this repo, you should be able to push to PR branches from forks. And I'm confident @seberg will be ok with it, as that's how he, @jakirkham , and I have been collaborating on the other NumPy 2.x PRs like rapidsai/cuspatial#1441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #4615