Fix from_pandas_edgelist with duplicate edges
#4653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a `Graph` or `DiGraph`, duplicate edges should be dropped. Also, ensure arrays are contiguous when creating the PLC graph, which can lead to incorrect results.
eriknw
added
bug
|
I added a workaround for cupy/cupy#8326: we now use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a
GraphorDiGraph, duplicate edges should be dropped. Also, ensure arrays are contiguous when creating the PLC graph, which can lead to incorrect results.For now, this was done by splitting out functionality from
relabel_nodes, but I wonder if there could be a faster way to deduplicate when edge values also need handled.Also,
cp.uniquewas sometimes problematic for me on larger data sets, but I may have been running out of device memory. @rlratzel I'm curious how this will perform for you.