Update Sampling API prior to MTMG integration. #4646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re MTMG integration
jnke2016
reviewed
Sep 17, 2024
| std::optional<rmm::device_uvector<edge_type_t>>, | ||
| std::optional<rmm::device_uvector<int32_t>>, | ||
| std::optional<rmm::device_uvector<size_t>>> | ||
| homogeneous_uniform_neighbor_sample( |
There was a problem hiding this comment.
I believe we discussed that the API should have two categories: Heterogeneous_neighbor_sample and Homogeneous_neighbor_sample where each category supports uniform and bias
seunghwak
reviewed
Sep 21, 2024
| std::get<0>(label_to_output_comm_rank).begin(), | ||
| std::get<0>(label_to_output_comm_rank).end(), | ||
| std::get<1>(label_to_output_comm_rank).begin(), | ||
| label_map.begin()); |
There was a problem hiding this comment.
You mean thrust::scatter?
|
|
||
| label_map.resize(max_label, handle.get_stream()); | ||
|
|
||
| thrust::fill(handle.get_thrust_policy(), label_map.begin(), label_map.end(), label_t{0}); |
There was a problem hiding this comment.
I guess the fill value should be an int32_t value (not label_t{0}).
|
Incorporated into @jnke2016 PR... closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut at new sampling function definition to clean up things before MTMG integration.
This overlaps some with @jnke2016 work on heterogeneous sampling... we'll need to resolve a merge order once we've decided on the exact API changes and sequence of work.
Latest thought is that this will be merged into @jnke2016's PR and this will be closed once it's no longer needed.