Biased Random Walks and Node2Vec implementation #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/MG and N2V SG: Passing all tests N2V MG: failing larger datasets
ChuckHastings
added
improvement
|
/ok to test |
|
/ok to test |
|
/ok to test |
ChuckHastings
commented
Sep 11, 2024
| num_unique_keys = local_frontier_unique_key_sizes[i]] __device__(key_t key) { | ||
| unique_key_last = get_dataframe_buffer_begin(aggregate_local_frontier_unique_keys) + | ||
| local_frontier_unique_key_displacements[i] + | ||
| local_frontier_unique_key_sizes[i]] __device__(key_t key) { |
There was a problem hiding this comment.
Note, passing num_unique_keys was failing on CUDA 11.8. Not sure why, seems like perhaps a compiler bug. Passing first and last worked on both CUDA 11.8 and CUDA 12.
There was a problem hiding this comment.
I have seen the issue especially in lambda functions hence now I often pass first and last
jnke2016
approved these changes
Sep 12, 2024
naimnv
approved these changes
Sep 12, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4499
Closes #4499
@G-Cornett implemented biased random walks and node2vec during his internship. This PR includes his changes to implement those algorithms.