-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Implement Link Prediction in cuGraph-PyG #4641
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
feature request
New feature or request
Blocked
Cannot progress due to external reasons
non-breaking
Non-breaking change
and removed
python
labels
Aug 30, 2024
…to pyg-linkpred
… into pyg-linkpred
… into pyg-linkpred
rlratzel
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this code and the PR is quite large, but I didn't see anything that jumped out as a problem.
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Adds support for negative sampling in `pylibcugraph` and `cugraph-pyg`. Closes rapidsai/cugraph-gnn#39 Merge after #4641 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Rick Ratzel (https://github.com/rlratzel) URL: #4660
Included in #4660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blocked
Cannot progress due to external reasons
feature request
New feature or request
non-breaking
Non-breaking change
python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the distributed sampler and cuGraph-PyG samplers and loaders to support link prediction. Currently does not support negative sampling. Resolves an issue where very small minibatches were interpreted as COO instead of CSR.
Also fixes a bug where the cuGraph-PyG
GraphStore
object calculated the number of vertices incorrectly for homogeneous graphs, which was encountered when testing link prediction on small batches.Merge after #4628
Closes #2992