Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Implement Link Prediction in cuGraph-PyG #4641

Closed
wants to merge 32 commits into from

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Aug 30, 2024

Updates the distributed sampler and cuGraph-PyG samplers and loaders to support link prediction. Currently does not support negative sampling. Resolves an issue where very small minibatches were interpreted as COO instead of CSR.

Also fixes a bug where the cuGraph-PyG GraphStore object calculated the number of vertices incorrectly for homogeneous graphs, which was encountered when testing link prediction on small batches.

Merge after #4628
Closes #2992

@alexbarghi-nv alexbarghi-nv self-assigned this Aug 30, 2024
@alexbarghi-nv alexbarghi-nv added feature request New feature or request Blocked Cannot progress due to external reasons non-breaking Non-breaking change and removed python labels Aug 30, 2024
@github-actions github-actions bot added the python label Sep 3, 2024
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review September 18, 2024 18:49
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this code and the PR is quite large, but I didn't see anything that jumped out as a problem.

rapids-bot bot pushed a commit that referenced this pull request Sep 30, 2024
Adds support for negative sampling in `pylibcugraph` and `cugraph-pyg`.

Closes rapidsai/cugraph-gnn#39
Merge after #4641

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4660
@alexbarghi-nv
Copy link
Member Author

Included in #4660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Cannot progress due to external reasons feature request New feature or request non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA]: Support sample_from_edges in PyG cuGraph Sampler
2 participants