-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune workflows based on changed files #4634
Prune workflows based on changed files #4634
Conversation
Only run tests based on things that have actually changed. For example, if only Python files have changed, we don't need to run the C++ tests. Contributes to rapidsai/build-planning#94
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not up to date on the changed-files work, so my review shouldn't count towards a merge. I left one other comment for your consideration.
I'll get caught up today and could leave a more thoughtful review later today, if you still don't have a ci-codeowners
approval by then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ build side rules look good
/merge |
Removes some exclusions left behind in #4634, to ensure that all CI is re-run when files in `.github/workflows` are chagned. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #4723
Only run tests based on things that have actually changed. For example, if only Python files have changed, we don't need to run the C++ tests.
Contributes to rapidsai/build-planning#94
Depends on rapidsai/shared-workflows#239