Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune workflows based on changed files #4634

Merged
merged 24 commits into from
Oct 1, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Aug 27, 2024

Only run tests based on things that have actually changed. For example, if only Python files have changed, we don't need to run the C++ tests.

Contributes to rapidsai/build-planning#94

Depends on rapidsai/shared-workflows#239

Only run tests based on things that have actually changed. For
example, if only Python files have changed, we don't need to run
the C++ tests.

Contributes to rapidsai/build-planning#94
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 27, 2024 17:17
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 27, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 30, 2024 20:46
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot removed the python label Sep 16, 2024
.github/workflows/pr.yaml Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not up to date on the changed-files work, so my review shouldn't count towards a merge. I left one other comment for your consideration.

I'll get caught up today and could leave a more thoughtful review later today, if you still don't have a ci-codeowners approval by then.

@KyleFromNVIDIA KyleFromNVIDIA changed the base branch from branch-24.10 to branch-24.12 September 26, 2024 20:55
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ build side rules look good

@BradReesWork BradReesWork modified the milestones: 24.10, 24.12 Sep 30, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0edb4c3 into rapidsai:branch-24.12 Oct 1, 2024
69 checks passed
rapids-bot bot pushed a commit that referenced this pull request Oct 23, 2024
Removes some exclusions left behind in #4634, to ensure that all CI is re-run when files in `.github/workflows` are chagned.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #4723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants