Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nx-cugraph Benchmarking Scripts #4616

Merged
merged 22 commits into from
Aug 31, 2024
Merged

Add nx-cugraph Benchmarking Scripts #4616

merged 22 commits into from
Aug 31, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Aug 19, 2024 •
edited
Loading

Closes https://github.com/rapidsai/graph_dl/issues/596
This PR adds scripts written by @rlratzel to generate benchmarking numbers for nx-cugraph

@nv-rliu nv-rliu requested review from eriknw and rlratzel August 19, 2024 22:51
@nv-rliu nv-rliu marked this pull request as ready for review August 26, 2024 18:48
@nv-rliu nv-rliu requested a review from a team as a code owner August 26, 2024 18:48
acostadon
acostadon approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It might be good to put an approximate runtime just so users know what they are in for. Even a single example with a specified architecture might set expectations.

This looks great though !!

benchmarks/nx-cugraph/pytest-based/run-gap-benchmarks.sh Outdated Show resolved Hide resolved
@nv-rliu nv-rliu added this to the 24.10 milestone Aug 27, 2024
@nv-rliu nv-rliu added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 27, 2024
rlratzel
rlratzel reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the README. I just had a few hopefully small requests.

benchmarks/nx-cugraph/pytest-based/README.md Outdated Show resolved Hide resolved
benchmarks/nx-cugraph/pytest-based/create_results_summary_page.py Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 996c7a4 into rapidsai:branch-24.10 Aug 31, 2024
104 checks passed
@nv-rliu nv-rliu deleted the nxcg-benchmarking branch August 31, 2024 04:17
@nv-rliu nv-rliu mentioned this pull request Sep 6, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Sep 11, 2024
@nv-rliu
Add --cpu-only or --gpu-only Arguments to nx-cugraph Benchmark (#…
a4baa5b 
…4648)

This PR is a follow-up to #4616

This PR adds the following CLI argument options for `benchmarks/nx-cugraph/pytest-based/run-main-benchmarks.sh` 
 - `--cpu-only`
 - `--gpu-only`

And adds minor updates to the README

Authors:
  - Ralph Liu (https://github.com/nv-rliu)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@rlratzel rlratzel rlratzel approved these changes

@eriknw eriknw Awaiting requested review from eriknw

Assignees
No one assigned
Labels
benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.10
Development

Successfully merging this pull request may close these issues.
3 participants
@nv-rliu @rlratzel @acostadon