Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ucx-py version, use UCX 1.17.0 in pip devcontainers #4562

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix ucx-py version, use UCX 1.17.0 in pip devcontainers #4562

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c12086a
Fix ucx-py dependency in update-version.sh
bdice Jul 29, 2024
7954eec
Don't double-replace ucx-py.
bdice Jul 29, 2024
58bd1c8
Merge branch 'branch-24.10' into fix-ucx-py-version
jameslamb Jul 30, 2024
6e61cd6
Update pip devcontainers to UCX v1.17.0
jameslamb Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ci/release/update-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,17 @@ DEPENDENCIES=(
ucx-py
bdice marked this conversation as resolved.
Show resolved Hide resolved
rapids-dask-dependency
)
for DEP in "${DEPENDENCIES[@]}"; do
for FILE in dependencies.yaml conda/environments/*.yaml python/cugraph-{pyg,dgl}/conda/*.yaml; do
for FILE in dependencies.yaml conda/environments/*.yaml python/cugraph-{pyg,dgl}/conda/*.yaml; do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched the iteration order of this double-for loop. That way we only find-replace ucx-py one time instead of once for every other dependency.

for DEP in "${DEPENDENCIES[@]}"; do
sed_runner "/-.* ${DEP}\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*/==${NEXT_SHORT_TAG_PEP440}.*,>=0.0.0a0/g" "${FILE}"
sed_runner "/-.* ucx-py==/ s/==.*/==${NEXT_UCX_PY_VERSION}.*,>=0.0.0a0/g" "${FILE}"
done
for FILE in python/**/pyproject.toml python/**/**/pyproject.toml; do
sed_runner "/-.* ucx-py\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*/==${NEXT_UCX_PY_VERSION}.*,>=0.0.0a0/g" "${FILE}"
Copy link
Contributor Author

@bdice bdice Jul 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important change is that the ucx-py logic was not handling -cu11 / -cu12 suffixes. Now it does.

done
for FILE in python/**/pyproject.toml python/**/**/pyproject.toml; do
for DEP in "${DEPENDENCIES[@]}"; do
sed_runner "/\"${DEP}\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*\"/==${NEXT_SHORT_TAG_PEP440}.*,>=0.0.0a0\"/g" "${FILE}"
sed_runner "/\"ucx-py==/ s/==.*\"/==${NEXT_UCX_PY_VERSION}.*,>=0.0.0a0\"/g" "${FILE}"
done
sed_runner "/\"ucx-py\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*\"/==${NEXT_UCX_PY_VERSION}.*,>=0.0.0a0\"/g" "${FILE}"
done

# ucx-py version
Expand Down
4 changes: 2 additions & 2 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,11 +505,11 @@ dependencies:
- matrix:
cuda: "11.*"
packages:
- &ucx_py_cu11 ucx-py-cu11==24.10.*,>=0.0.0a0
- &ucx_py_cu11 ucx-py-cu11==0.40.*,>=0.0.0a0
- matrix:
cuda: "12.*"
packages:
- &ucx_py_cu12 ucx-py-cu12==24.10.*,>=0.0.0a0
- &ucx_py_cu12 ucx-py-cu12==0.40.*,>=0.0.0a0
- matrix:
packages:
- *ucx_py
Expand Down
Loading