[FIX] Skip Distributed Sampler Tests if PyTorch with CUDA is not Available #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Jul 2, 2024
|
Thanks! |
rlratzel
approved these changes
Jul 2, 2024
|
/merge |
|
C++ tests failed :( |
|
CC @ChuckHastings this looks like the same issue we were discussing last week and this morning. Is the error intermittent for now, i.e. will rerunning be an OK approach until the test's memory usage gets fixed? |
|
I would try rerunning, I believe this is non-deterministic. We are discussing a fix, I'll try and link the PR here. |
rapids-bot
bot
merged commit e299a59
into
rapidsai:branch-24.08
131 of 132 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nightly tests are failing because there is no CUDA-supporting version of PyTorch available (as expected, i.e. on CUDA 11.4). Instead, the CPU version of PyTorch gets installed, and the test crashes when attempting to set the CUDA allocator. This PR disables those tests when only a CPU version of PyTorch is available to prevent this from happening.