[FEA] New Graph Interface and Loaders for Distributed Sampling in DGL #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
feature request
…cugraph into dgl-dist-sampling
VibhuJawa
reviewed
Jul 9, 2024
Co-authored-by: Vibhu Jawa <[email protected]>
Co-authored-by: Vibhu Jawa <[email protected]>
…cugraph into dgl-dist-sampling
Co-authored-by: Vibhu Jawa <[email protected]>
…cugraph into dgl-dist-sampling
I added |
VibhuJawa
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
LGTM, thanks for all the changes @alexbarghi-nv , Looks good to go from my side
raydouglass
approved these changes
Jul 12, 2024
rlratzel
approved these changes
Jul 31, 2024
Comment on lines
+35
to
+36
| # Have to use import_optional even though these are required | ||
| # dependencies in order to build properly. |
There was a problem hiding this comment.
That's interesting, and unfortunate. I'm glad you added this comment.
|
/merge |
rapids-bot
bot
merged commit b38e010
into
rapidsai:branch-24.08
130 of 131 checks passed
alexbarghi-nv
added a commit
to rapidsai/cugraph-gnn
that referenced
this pull request
Aug 14, 2024
seberg
added a commit
to seberg/cugraph
that referenced
this pull request
Aug 24, 2024
See rapidsaigh-4486 for adding torchdata/pydantic and rapidsaigh-4464 for introducing the torch pin due to NCCL difficulties. It is entirely possible that this still fails due to the NCCL issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DGLGraphFeatureStorageThis PR also adds
pydanticandtorchdataas test dependencies of cuGraph-DGL, because they are unlisted runtime dependencies of the latest version of DGL (which we will be testing with in the newcugraph-gnnrepository).This PR also changes the test file structure to match the rest of cuGraph, by using the _mg suffix to denote multi-GPU tests and moving them to the main directory under "tests".
New examples will be added in a future PR. This PR is just for basic functionality and tests.
Closes #3805
Closes rapidsai/cugraph-gnn#4
Closes #4400
Closes #4247
Closes #3303