Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for On-Going MG Test Failures #4450

Merged
merged 16 commits into from
Jun 4, 2024
Merged

Fixes for On-Going MG Test Failures #4450

merged 16 commits into from
Jun 4, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented May 29, 2024 •
edited
Loading

This PR fixes bugs and FutureWarnings that were causing the nightly MG test suite to fail.

@nv-rliu nv-rliu added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 29, 2024
@nv-rliu nv-rliu added this to the 24.08 milestone May 29, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 29, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nv-rliu
Copy link
Contributor Author

nv-rliu commented Jun 4, 2024

/mnmg test conda 2 8

@nv-rliu nv-rliu marked this pull request as ready for review June 4, 2024 18:23
@nv-rliu nv-rliu requested a review from a team as a code owner June 4, 2024 18:23
rlratzel
rlratzel approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rlratzel
Copy link
Contributor

rlratzel commented Jun 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit c8b04c7 into rapidsai:branch-24.08 Jun 4, 2024
131 checks passed
@nv-rliu nv-rliu deleted the fix-nightly-tests branch June 5, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.
2 participants
@nv-rliu @rlratzel