Add Additional Checks to get_edgelist and get_dask_edgelist
#4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
improvement
|
@nv-rliu and I discussed this offline earlier today and I believe he has a change in mind for this PR that eliminates the need for the additional |
nv-rliu
changed the title
overwrite Argument to datasets.get_graph()get_edgelist and get_dask_edgelist
rlratzel
requested changes
Apr 10, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4241
This PR adds an additional check to the
get_edgelist()andget_dask_edgelist()functions in the Datasets API.This ensures that, when retrieving an edge-list, the internal (
self._edgelist) type is verified to ensure that the object is SG or MG.In addition, minor improvements have also been made
utils/test_dataset.pyto be more thorough with type checks.