Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pytest failures on warnings from cudf #4223

Merged
merged 17 commits into from
Mar 17, 2024
Merged

Enable pytest failures on warnings from cudf #4223

merged 17 commits into from
Mar 17, 2024

Conversation

mroeschke
Copy link
Contributor

In 24.04, cudf issues a FutureWarning when using positional indexing with __getitem__. The change here is to use iloc instead.

Additionally the test suite will now fail when a warning comes from cudf as apart of rapidsai/build-planning#26

@mroeschke mroeschke requested a review from a team as a code owner March 8, 2024 03:04
@github-actions github-actions bot added the python label Mar 8, 2024
acostadon
acostadon requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the schedule to merge this?
Is it for 24.04?

@mroeschke
Copy link
Contributor Author

What is the schedule to merge this? What is the schedule to merge this?
Is it for 24.04?

This is not critical for 24.04. Fine to de-prioritize over other PRs

rlratzel
rlratzel approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
We should have treated cudf warnings as test failures long ago.

@BradReesWork
Copy link
Member

All - can we get this is as soon as possible. while the warnings do not stop an analytic, is still looks bad on us to even have warrings

acostadon
acostadon approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !!!

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2024
@BradReesWork BradReesWork added this to the 24.04 milestone Mar 11, 2024
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a467da9 into rapidsai:branch-24.04 Mar 17, 2024
137 checks passed
@mroeschke mroeschke deleted the tests/pytest/warning_failure branch March 18, 2024 16:11
@mroeschke mroeschke mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
5 participants
@mroeschke @BradReesWork @rlratzel @acostadon @nv-rliu