Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #4217

Merged
merged 17 commits into from
Mar 13, 2024
Merged

Remove hard-coding of RAPIDS version where possible #4217

merged 17 commits into from
Mar 13, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

  • Read VERSION file in CMake
  • Read cugraph.__version__ in docs build
  • Read VERSION file in shell scripts
  • Use environment variables in Doxyfile
  • Remove updates from ci/update-version.sh

Issue: rapidsai/build-planning#15

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 5, 2024 22:16
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 5, 2024
@jakirkham
Copy link
Member

Thanks Kyle! 🙏

Think we can also make these changes: rapidsai/build-planning#15 (comment) + rapidsai/build-planning#15 (comment)

@KyleFromNVIDIA
Copy link
Contributor Author

It seems that cugraph is already using that approach:

cugraph/python/cugraph/pyproject.toml

Line 23 in c17ba39

dynamic = ["version"]

acostadon
acostadon approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes look good

ChuckHastings
ChuckHastings approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++/CUDA changes look good

@bdice
Copy link
Contributor

bdice commented Mar 12, 2024

/merge

@BradReesWork BradReesWork added this to the 24.04 milestone Mar 13, 2024
@BradReesWork
Copy link
Member

/merge

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 3086f83 into rapidsai:branch-24.04 Mar 13, 2024
137 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@rlratzel rlratzel mentioned this pull request Mar 14, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Mar 15, 2024
@rlratzel
Removes (unintentional?) runtime dependency on packaging from nx-cu…
6d45e7b 
…graph (#4240)

A [recent PR](#4217) was merged that added `packaging` as a runtime dependency to nx-cugraph.  This PR removes that dependency and manually extracts the `major` and `minor` version numbers instead.

Authors:
  - Rick Ratzel (https://github.com/rlratzel)
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Erik Welch (https://github.com/eriknw)

URL: #4240
@jameslamb jameslamb mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
ci CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
7 participants
@KyleFromNVIDIA @jakirkham @bdice @BradReesWork @ChuckHastings @AyodeAwe @acostadon