Add cuda-nvtx-dev, add missing CUDA library dependencies. #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
Merged
naimnv
reviewed
Feb 10, 2024
Comment on lines
+330
to
+336
| - cuda-cudart-dev | ||
| - cuda-nvtx-dev | ||
| - cuda-profiler-api | ||
| - libcublas-dev | ||
| - libcurand-dev | ||
| - libcusolver-dev | ||
| - libcusparse-dev |
There was a problem hiding this comment.
Just curious, why packages other than cuda-nvtx-dev needed here?
There was a problem hiding this comment.
They're build dependencies of cugraph. These are listed in the conda recipes. However, they've been coming transitively as dependencies of libraft. We should be explicit about the libraries that are used rather than relying on them coming from raft.
4 tasks
AyodeAwe
approved these changes
Feb 12, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with devcontainer builds where
cuda-nvtx-devwas missing when buildinglibcugraph_etl.