Removes the networkx_algorithm decorator to all SCC functions to disable dispatching to them
#4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble dispatching until cugraph SCC can be improved.
eriknw
approved these changes
Jan 27, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cugraph
strongly_connected_componentsis a legacy implementation with known issues, and in most cases should not be used until the cugraph team can provide an update.This PR removes the
networkx_algorithmdecorator from all SCC functions to disable dispatching. Users can still run the SCC functions here by accessing them directly fromnx_cugraph:Tested by running the
nx_cugraphtests (pytest nx_cugraph/tests) and the NetworkX tests (run_nx_tests.sh)Note: using the "non-breaking" label since this API was only present in nightlies and never released.