Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor CUDA versions in dependencies.yaml #4084

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

  • prevents accidental inclusion of multiple cuda-version version in environments
  • reduces update effort (via enabling more use of globs like "12.*")
  • improves the chance that errors like "conda recipe is missing a dependency" are caught in CI

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
vyasr
vyasr previously requested changes Jan 11, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought the error here was just a timeout, but it looks like it's caused by a real underlying issue. Are we tracking that anywhere in cugraph? If not, should probably open an issue/ping people on Slack.

@bdice
Copy link
Contributor

bdice commented Jan 11, 2024

@vyasr It looks like #4083 touched some relevant code here. I merged in the upstream to see if that helps.

@raydouglass raydouglass requested a review from vyasr January 11, 2024 15:35
@jameslamb
Copy link
Member Author

I merged in the upstream to see if that helps.

Thanks for that! Seems like it did help.

@raydouglass raydouglass dismissed vyasr’s stale review January 11, 2024 15:38

Issue is fixed

@bdice
Copy link
Contributor

bdice commented Jan 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit b22dd99 into rapidsai:branch-24.02 Jan 11, 2024
97 checks passed
@jameslamb jameslamb deleted the rework-dependencies branch January 11, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants