Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuGraph-DGL and WholeGraph Performance Testing with Feature Store Performance Improvements #4081

Merged
merged 554 commits into from
Mar 11, 2024
Merged

cuGraph-DGL and WholeGraph Performance Testing with Feature Store Performance Improvements #4081

merged 554 commits into from
Mar 11, 2024

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Jan 8, 2024 •
edited
Loading

Large-scale cuGraph-DGL performance testing scripts. Also changes the DGL and PyG scripts to evaluate on all ranks and reuse the test samples, and adds support for benchmarking cuGraph-DGL/cuGraph-PyG with WholeGraph.

Updates cuGraph.gnn.FeatureStore and cuGraph-PyG for increased performance:

  • Supporting passing in a WG embedding directly to cugraph.gnn.FeatureStore
  • Simplifying how cuGraph-PyG handles filtering and using a cache to prevent repeatedly copying data between the device and host
  • Fix bug in cugraph.gnn.FeatureStore where indexing with a gpu tensor would raise an exception, especially with WG
  • Add a function to cugraph.gnn.FeatureStore to check where data is stored, which is used by cuGraph-PyG to prevent unnecessary d2h and h2d copies

Merge after #3584

alexbarghi-nv and others added 30 commits September 1, 2023 15:00
@alexbarghi-nv
Merge branch 'branch-23.10' into cugraph-pyg-loader-improvements
e9b39e4
@alexbarghi-nv
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
d99b512 
…ugraph-sample-convert
@alexbarghi-nv
the c api
c15d580
@alexbarghi-nv
work
2ac8b86
@alexbarghi-nv
fix compile errors
9135629
@alexbarghi-nv
reformat
dfd1cb7
@seunghwak
rename test file from .cu to .cpp
6dfd4fe
@alexbarghi-nv
Merge branch 'branch-23.10' into cugraph-pyg-loader-improvements
f600520
@seunghwak
bug fixes
7d5821f
@seunghwak
add fill wrapper
58189ed
@seunghwak
undo adding fill wrapper
39db98a
@seunghwak
sampling test from .cpp to .cu
98c8e0a
@alexbarghi-nv
latest perf testing
687d191
@seunghwak
fix a typo
c151f95
@seunghwak
Merge branch 'branch-23.10' of github.com:rapidsai/cugraph into fea_mfg
fc5a4f0
@alexbarghi-nv
merge
a7d1804
@alexbarghi-nv
Merge branch 'branch-23.10' of https://github.com/rapidsai/cugraph in…
3cda233 
…to perf-testing-v2
@alexbarghi-nv
do merge
0a18cde
@seunghwak
do not return valid nzd vertices if doubly_compress is false
094aaf9
@seunghwak
bug fix
cf57a6d
@seunghwak
test code
2b48b7e
@seunghwak
Merge branch 'branch-23.10' of github.com:rapidsai/cugraph into fea_mfg
79acc8e
@alexbarghi-nv
Merge branch 'branch-23.10' into cugraph-pyg-loader-improvements
11009c6
@alexbarghi-nv
Merge branch 'branch-23.10' into cugraph-sample-convert
0481bfb
@alexbarghi-nv
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
2af9333 
…ugraph-sample-convert
@seunghwak
bug fix
23cd2c2
@seunghwak
update documentation
6eaf67e
@alexbarghi-nv
fix c api issues
4dc0a92
@alexbarghi-nv
Merge branch 'branch-23.10' of https://github.com/rapidsai/cugraph in…
2947b33 
…to cugraph-sample-convert
@alexbarghi-nv
C API fixes, Python/PLC API work
0a2b2b7
@alexbarghi-nv
Copy link
Member Author

/ok to test

1 similar comment
@alexbarghi-nv
Copy link
Member Author

/ok to test

@BradReesWork
Copy link
Member

/ok to test

@alexbarghi-nv alexbarghi-nv added the DO NOT MERGE Hold off on merging; see PR for details label Feb 28, 2024
@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv alexbarghi-nv removed the DO NOT MERGE Hold off on merging; see PR for details label Mar 4, 2024
@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/ok to test

@rapids-bot rapids-bot bot merged commit 4f4be6e into rapidsai:branch-24.04 Mar 11, 2024
137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naimnv naimnv naimnv approved these changes

@VibhuJawa VibhuJawa VibhuJawa requested changes

@acostadon acostadon acostadon approved these changes

@jnke2016 jnke2016 jnke2016 approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
benchmarks feature request New feature or request non-breaking Non-breaking change python
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
7 participants
@alexbarghi-nv @BradReesWork @VibhuJawa @jnke2016 @acostadon @naimnv @seunghwak