Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build wheels for cugraph-dgl and cugraph-pyg #4075

Merged
merged 14 commits into from
Jan 9, 2024
Merged

build wheels for cugraph-dgl and cugraph-pyg #4075

merged 14 commits into from
Jan 9, 2024

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Jan 2, 2024

Closes #4061

@tingyu66 tingyu66 added this to the 24.02 milestone Jan 2, 2024
@tingyu66 tingyu66 self-assigned this Jan 2, 2024
@github-actions github-actions bot added the ci label Jan 2, 2024
@tingyu66 tingyu66 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed ci labels Jan 2, 2024
@tingyu66 tingyu66 marked this pull request as ready for review January 9, 2024 03:54
@tingyu66 tingyu66 requested review from a team as code owners January 9, 2024 03:54
alexbarghi-nv
alexbarghi-nv approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AyodeAwe
Copy link
Contributor

AyodeAwe commented Jan 9, 2024

Is it relevant here to merge in the latest changes from the base branch?

@tingyu66
Copy link
Member Author

tingyu66 commented Jan 9, 2024

Is it relevant here to merge in the latest changes from the base branch?

Not really. This PR does not require the latest few commits.

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit cd5fc6f into rapidsai:branch-24.02 Jan 9, 2024
97 checks passed
@tingyu66 tingyu66 deleted the wheel_build branch January 9, 2024 20:20
@tingyu66 tingyu66 mentioned this pull request Jan 10, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Jan 10, 2024
@tingyu66
Correct cugraph-pyg package name used in wheels and fix test script (…
35ae8ef 
…#4083)

This is an oversight from #4075. With this fix, the generated wheels should have proper a CUDA suffix (e.g. `cugraph-pyg-cu12`).

Edit: This PR also fixes rapidsai/graph_dl#421 
The mg tests were not skipped as expected due to wrong relative path in `test_wheel_cugraph-pyg.sh`.

Authors:
  - Tingyu Wang (https://github.com/tingyu66)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Alex Barghi (https://github.com/alexbarghi-nv)

URL: #4083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees

@tingyu66 tingyu66

Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.02
Development

Successfully merging this pull request may close these issues.

Build wheels for cugraph-dgl and -pyg
3 participants
@tingyu66 @AyodeAwe @alexbarghi-nv