Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Fix invalid links and add materials to notebooks #4002

Merged
merged 14 commits into from
Nov 21, 2023

Conversation

huiyuxie
Copy link
Contributor

I'm new to CuGraph repository and would like to contribute further in the future. So I start with minor tasks with docs to familiarize myself with the contribution process in this repository.

Here is what I have done in this PR:

  • Fixed some invalid links in the documentation.
  • Corrected and added formulas related to centrality.
  • Added more references to the centrality to ensure consistency.

Also, the images located at https://github.com/rapidsai/cugraph/tree/main/python/cugraph cannot be displayed because it is symbolic link to the repository's README file. But it's not a major issue.

@huiyuxie huiyuxie requested a review from a team as a code owner November 15, 2023 08:30
Copy link

copy-pr-bot bot commented Nov 15, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@huiyuxie
Copy link
Contributor Author

Should be tagged with the doc label.

@BradReesWork BradReesWork added this to the 23.12 milestone Nov 15, 2023
@acostadon acostadon added doc Documentation non-breaking Non-breaking change labels Nov 15, 2023
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. This overlaps with PR #3938 and will be merged and deconflicted after that one is merged.

@acostadon acostadon added the DO NOT MERGE Hold off on merging; see PR for details label Nov 15, 2023
@acostadon
Copy link
Contributor

This can me merged and deconflicted after #3938 is merged.

@huiyuxie
Copy link
Contributor Author

Thank you all! I fixed one more place related to the formula.

@BradReesWork BradReesWork added the Blocked Cannot progress due to external reasons label Nov 17, 2023
@BradReesWork BradReesWork removed Blocked Cannot progress due to external reasons DO NOT MERGE Hold off on merging; see PR for details labels Nov 21, 2023
@BradReesWork
Copy link
Member

/ok to test

Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some nice improvements here. once merged we can check the links and change as necessary.

"\n",
"___Closeness centrality – coming soon___ <br>\n",
"__Closeness Centrality__ <br>\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coming soon was in here because this notebook doesn't include that algorithm,

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 332676e into rapidsai:branch-23.12 Nov 21, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants