Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try upgrading pip to fix devcontainer builds #4000

Closed
wants to merge 1 commit into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 15, 2023

If this works we probably want to upgrade pip in the underlying containers, not here.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Nov 15, 2023
@vyasr vyasr self-assigned this Nov 15, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Nov 15, 2023

The problem diagnosis in this PR is correct, but the solution doesn't work because the pip upgrade is happening after the problematic installation has already been attempted. We're going to get the underlying containers updated so that this works out of the box.

@vyasr vyasr closed this Nov 15, 2023
@vyasr vyasr reopened this Nov 15, 2023
@BradReesWork BradReesWork added this to the 23.12 milestone Nov 15, 2023
@vyasr vyasr closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants