-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix Graph Construction From Pandas in cuGraph-PyG #3985
[BUG] Fix Graph Construction From Pandas in cuGraph-PyG #3985
Conversation
…arghi-nv/cugraph into fix-large-pandas-dataframe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the dask changes and they look good to me, will review other bits after the
#3978 is merged in
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
…arghi-nv/cugraph into fix-large-pandas-dataframe
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only have a minor question.
/ok to test |
/merge |
Supports the `drop_last` argument in cuGraph-PyG for better compatibility with native PyG workflows. Closes #3949 Merge after #3985 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Naim (https://github.com/naimnv) Approvers: - Tingyu Wang (https://github.com/tingyu66) - Brad Rees (https://github.com/BradReesWork) - Vibhu Jawa (https://github.com/VibhuJawa) URL: #3995
The current graph construction creates a single pandas dataframe, which for larger datasets (i.e. ogbn-papers100M) cannot be serialized. This PR resolves this by breaking up the dataframe into scattered numpy arrays that are then reassembled.
Merge after #3978