Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates README file to include nx-cugraph user documentation, adds nx-cugraph to main README #3984

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Nov 7, 2023

  • Updates the nx-cugraph README file to include nx-cugraph user documentation
  • Adds nx-cugraph and new News section to main README
  • Updates software strack diagram to remove DGL and PyG since they are not currently using PropertyGraph or cugraph-service

@rlratzel rlratzel requested review from a team as code owners November 7, 2023 08:06
@rlratzel rlratzel self-assigned this Nov 7, 2023
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2023
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change - adding NetworkX to the list of projects using cuGraph

README.md Show resolved Hide resolved
img/Stack2.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should update this in release 24.02 to show cuGraph-DGL, cuGraph-PyG, cuGraph-ops, WholeGraph, etc. I'll link an issue here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3986

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software stack image is also really out of date (@acostadon ). That is part of the 24.02 make everything perfect push

Copy link

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion and one question on install

README.md Outdated Show resolved Hide resolved
```
$ pytest --bench
python -m pip install nx-cugraph-cu11 --extra-index-url https://pypi.nvidia.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a --pre or >=23.10.0a0 specifier since the latest changes? @vyasr may know. Maybe based on the note below about these being non-nightlies it's not an issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I was relying on the note below that since (I don't believe) we have a way to provide nightly 23.12 wheels. Although if there is a way I'm not aware of, I'd love to be able to describe how users can get nightly 23.12 wheels. @vyasr any thoughts?

Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw a place where the notebook was mentioned out of place.

python/nx-cugraph/README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
img/Stack2.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software stack image is also really out of date (@acostadon ). That is part of the 24.02 make everything perfect push

@raydouglass raydouglass merged commit 77bb291 into rapidsai:branch-23.12 Nov 8, 2023
50 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants