Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HeteroGATConv to cugraph-pyg #3914

Merged
merged 11 commits into from
Dec 11, 2023
Merged

Add HeteroGATConv to cugraph-pyg #3914

merged 11 commits into from
Dec 11, 2023

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Oct 5, 2023 •
edited
Loading

Fixes https://github.com/rapidsai/graph_dl/issues/311
Adding @stadlmax POC code to cugraph-pyg

@tingyu66 tingyu66 requested a review from a team as a code owner October 5, 2023 03:11
@tingyu66 tingyu66 marked this pull request as draft October 5, 2023 03:12
@tingyu66 tingyu66 self-assigned this Oct 5, 2023
@BradReesWork BradReesWork added this to the 23.12 milestone Oct 5, 2023
@tingyu66 tingyu66 requested a review from stadlmax October 6, 2023 17:02
@stadlmax
Copy link
Contributor

stadlmax commented Oct 9, 2023

Looks good to me, but it would also be great if we could add a test against PyG like for other operators. The initialization should match PyG, so both this and the general primitive ideally should be tested for correctness. :)

@tingyu66
Copy link
Member Author

tingyu66 commented Oct 9, 2023

Looks good to me, but it would also be great if we could add a test against PyG like for other operators. The initialization should match PyG, so both this and the general primitive ideally should be tested for correctness. :)

Sure, will test against PyG's HeteroConv + PyG's GATConv. What does "general primitive" here refer to?

@stadlmax
Copy link
Contributor

stadlmax commented Oct 9, 2023

Sure, will test against PyG's HeteroConv + PyG's GATConv. What does "general primitive" here refer to?

just the conv layer vs. the initialization of it

@tingyu66 tingyu66 modified the milestones: 23.12, 24.02 Nov 15, 2023
@tingyu66 tingyu66 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2023
@tingyu66 tingyu66 changed the base branch from branch-23.12 to branch-24.02 November 17, 2023 03:48
@tingyu66 tingyu66 marked this pull request as ready for review November 17, 2023 03:49
@tingyu66
Copy link
Member Author

tingyu66 commented Dec 4, 2023

@stadlmax I have added a test to validate against PyG. Could you review it again?

@github-actions github-actions bot added the python label Dec 5, 2023
@tingyu66 tingyu66 requested a review from a team December 8, 2023 17:52
alexbarghi-nv
alexbarghi-nv approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 1655003 into rapidsai:branch-24.02 Dec 11, 2023
75 checks passed
@tingyu66 tingyu66 deleted the heterogatconv branch December 12, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stadlmax stadlmax stadlmax left review comments

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@tingyu66 tingyu66

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.02
Development

Successfully merging this pull request may close these issues.
4 participants
@tingyu66 @stadlmax @alexbarghi-nv @BradReesWork